Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step arguments are no longer fixtures #493

Merged
merged 3 commits into from
Jan 15, 2022
Merged

Conversation

olegpidsadnyi
Copy link
Contributor

Step parsed arguments often conflict with the fixtures. There's no real reason for these arguments to define fixtures.
If step has to introduce a fixture the target_fixture parameter should be used.

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #493 (8133dc2) into master (6730b42) will decrease coverage by 0.08%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   95.56%   95.48%   -0.09%     
==========================================
  Files          49       48       -1     
  Lines        1579     1573       -6     
  Branches      171      171              
==========================================
- Hits         1509     1502       -7     
  Misses         44       44              
- Partials       26       27       +1     
Impacted Files Coverage Δ
tests/feature/test_multiline.py 100.00% <ø> (ø)
tests/feature/test_outline.py 100.00% <ø> (ø)
tests/feature/test_report.py 75.67% <ø> (ø)
pytest_bdd/scenario.py 91.07% <88.88%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6730b42...8133dc2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant