-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsers.re
doing only partial string match
#539
Conversation
This makes it work the same way other parsers work (they don't ignore non-matching characters at the end of the string)
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 92.43% 92.46% +0.02%
==========================================
Files 49 49
Lines 1679 1685 +6
Branches 208 208
==========================================
+ Hits 1552 1558 +6
Misses 90 90
Partials 37 37
Continue to review full report at Codecov.
|
FWIW this broke a couple of tests for me where I used trailing periods: qutebrowser/qutebrowser@418f91d Is that intended? I'm guessing yes, but I have no idea how other Gherkin parsers handle this. |
It is expected to break a few steps indeed, I will release a new major version for this. maybe I’ll mention in the release notes how to migrate to this, although I assume that if you use regex, you know how to consume all characters at the end of the string. |
Fix `parsers.re` doing only partial string match
Fix `parsers.re` doing only partial string match
This PR make sure that
parsers.re
does a fullmatch of the re, rather than ignoring non-matching characters at the end of the string.All the other parsers already work this way, there is no reason for
parsers.re
not to.Checklist