Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call pytest_bdd_after_scenario hook after all steps have finished #577

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

skarimo
Copy link
Contributor

@skarimo skarimo commented Nov 7, 2022

Currently, the pytest_bdd_after_scenario hook runs after every step. It should run once after all the steps have completed.

@therve
Copy link

therve commented Nov 8, 2022

Looks l like a regression of #534 @youtux

@youtux
Copy link
Contributor

youtux commented Nov 8, 2022

ah yes, sorry for this.

@youtux youtux changed the base branch from master to 6.x November 8, 2022 16:39
@youtux youtux changed the base branch from 6.x to master November 8, 2022 16:39
@youtux youtux enabled auto-merge November 8, 2022 16:39
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 95.29% // Head: 95.51% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (ec24331) compared to base (780a677).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   95.29%   95.51%   +0.21%     
==========================================
  Files          49       48       -1     
  Lines        1742     1738       -4     
  Branches      190      190              
==========================================
  Hits         1660     1660              
+ Misses         54       50       -4     
  Partials       28       28              
Impacted Files Coverage Δ
src/pytest_bdd/scenario.py 93.01% <100.00%> (ø)
tests/utils.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@youtux youtux disabled auto-merge November 8, 2022 16:42
@youtux youtux merged commit c3b8cd0 into pytest-dev:master Nov 8, 2022
@youtux
Copy link
Contributor

youtux commented Nov 8, 2022

I just released version 6.1.1 to PyPI with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants