Capture Qt log messages #40

nicoddemus · 2015-04-27T23:18:27Z

WIP:

Capture and display Qt messages
Disable capture using command line
Implement fixture to access captured messages
Control formatting using command line
Option to output messages directly to stderr instead of capturing them (in discussion: Capturing Qt logging #39)
Docs

Fixes #39

coveralls · 2015-04-27T23:28:57Z

Coverage decreased (-1.71%) to 98.29% when pulling 89388e5 on logging into a48b50b on master.

Now using hookwrapper decorator, supported only by >= 2.7

Use utf-8 as a guess here, but make sure encoding errors don't prevent a message from being displayed

coveralls · 2015-04-27T23:42:10Z

Coverage decreased (-2.38%) to 97.62% when pulling 7d8b729 on logging into a48b50b on master.

coveralls · 2015-04-29T01:45:11Z

Coverage decreased (-2.34%) to 97.66% when pulling de7f7c5 on logging into a48b50b on master.

The-Compiler · 2015-04-29T07:19:11Z

pytestqt/plugin.py

+        Method to be installed using qInstallMsgHandler, stores each message
+        into the `messages` attribute.
+        """


isinstance(msg, bytes) is usually the more idomatic way to do this 😉

Though will this ever be a bytes object?

Thanks, changed it.

PyQt4 in Python 3 returns bytes... thought odd too.

Qt4's qInstallMsgHandler actually takes a QtMsgHandler which takes a const char * (Qt5 takes a QString) - so it actually makes sense to map that to a bytes object in Python3.

coveralls · 2015-04-29T23:19:35Z

Coverage decreased (-2.52%) to 97.48% when pulling 1ebf18f on logging into a48b50b on master.

coveralls · 2015-04-29T23:51:42Z

Coverage decreased (-2.52%) to 97.48% when pulling 465cbf2 on logging into a48b50b on master.

PyQt4 and PySide differ on this aspect, it seems

coveralls · 2015-04-30T00:12:47Z

Coverage decreased (-1.57%) to 98.43% when pulling 6e90e17 on logging into a48b50b on master.

coveralls · 2015-04-30T00:12:47Z

Coverage decreased (-1.57%) to 98.43% when pulling 6e90e17 on logging into a48b50b on master.

The-Compiler · 2015-04-30T14:15:11Z

pytestqt/_tests/test_logging.py

+        qtlog.messages = []
+
+
+def test_fixture_with_loggin_disabled(testdir):


loggin -> logging 😉

Fixed, thanks. 😄

coveralls · 2015-04-30T20:29:54Z

Coverage decreased (-1.57%) to 98.43% when pulling 344558a on logging into a48b50b on master.

Reuse same ideas and terminology from `logging` when possible

coveralls · 2015-05-01T16:52:07Z

Coverage decreased (-1.99%) to 98.01% when pulling cccffd4 on logging into a48b50b on master.

coveralls · 2015-05-01T16:52:07Z

Coverage decreased (-1.99%) to 98.01% when pulling cccffd4 on logging into a48b50b on master.

Also, selectively ignore coverage for certain lines that are tested in a separater process in the tests

coveralls · 2015-05-01T17:13:39Z

Coverage remained the same at 100.0% when pulling 6edbea3 on logging into a48b50b on master.

The-Compiler · 2015-05-07T04:45:58Z

pytestqt/plugin.py

+    parser.addoption('--no-qt-log', dest='qt_log', action='store_false',
+                     default=True)
+    parser.addoption('--qt-log-format', dest='qt_log_format',
+                     default='{rec.type_name}: {rec.message}')


Maybe those should also be .ini options? i.e. why is qt_no_exception_capture a config option, but --no-qt-log a commandline flag?

I was planning on add them as ini options too, but realized it is not really needed as the users can use addopts instead:

[pytest] addopts = --qt-log-format="{rec.type_name}"

(I have to remember to add this to the documentation)

qt_no_exception_capture is a config option because it is "part" of the configuration of the test suite, as it is not something the user should have to pass in the command line for the test suite to work. python_files follows the same idea, if a test suite uses ut_ prefix for test files, it makes sense that this is configured "permanently" in the ini file, instead of having to be passed every time on the command line.

Hope my somewhat contrived explanation makes sense. 😄

Conflicts: .travis.yml pytestqt/plugin.py

Capture Qt log messages

nicoddemus · 2015-06-06T21:13:52Z

Finally merged! 😅

Thanks for all the support @The-Compiler! 😄

Capture Qt log messages

89388e5

nicoddemus added 2 commits April 27, 2015 20:30

Drop support for pytest-2.6.4

77e7437

Now using hookwrapper decorator, supported only by >= 2.7

Decode msg obtained from QtMsgHandler

7d8b729

Use utf-8 as a guess here, but make sure encoding errors don't prevent a message from being displayed

Add support for disabling qt log capture using --no-qt-log option

de7f7c5

The-Compiler reviewed Apr 29, 2015
View reviewed changes

nicoddemus added 3 commits April 29, 2015 19:32

Use isinstance instead of type(), as suggested by @The-Compiler

c6495cf

Add qtlog fixture for logging capture

374dbeb

qtlog returns empty message lists with --qt-no-log option

1ebf18f

Try to fix PyQt4 build on Travis

465cbf2

Strip spaces after the end of message on tests

6e90e17

PyQt4 and PySide differ on this aspect, it seems

The-Compiler reviewed Apr 30, 2015
View reviewed changes

Fix typo in method name and docstring

344558a

nicoddemus added 3 commits May 1, 2015 12:59

Convert Message from a tuple into a proper class

b6ce650

Refactor Message into Record

aa2ee36

Reuse same ideas and terminology from `logging` when possible

Customize displayed records with qt-log-format command line option

cccffd4

Declare read-only properties in a compact way

6edbea3

Also, selectively ignore coverage for certain lines that are tested in a separater process in the tests

The-Compiler mentioned this pull request May 5, 2015

Way forward after adopt pytest month hackebrot/qutebrowser#26

Closed

The-Compiler reviewed May 7, 2015
View reviewed changes

nicoddemus added 3 commits May 16, 2015 17:26

Add docstrng for qt_compat module

1c12eac

Add qt_log_level_fail option

3e719fe

Add qt_log_level_fail mark

9c414d3

nicoddemus mentioned this pull request Jun 2, 2015

[WIP] Add waitSignals. #43

Merged

nicoddemus added 8 commits June 6, 2015 11:47

Merge remote-tracking branch 'origin/master' into logging

4726dfb

Conflicts: .travis.yml pytestqt/plugin.py

Syntax changes to work on py26

8e470b8

Fix import symbols for docs generation

9c85def

Add support for qt_log_ignore ini option

32f3831

Add qt_log_ignore mark

e35e333

Test multiple qt_log_ignore regexes on config file

fe92893

Update documentation for Qt logging

7ca57d7

Add multiple parameter test for qt_log_ignore mark

1184fbf

nicoddemus added a commit that referenced this pull request Jun 6, 2015

Merge pull request #40 from pytest-dev/logging

ce340a0

Capture Qt log messages

nicoddemus merged commit ce340a0 into master Jun 6, 2015

The-Compiler mentioned this pull request Jun 6, 2015

Log capturing breaks existing logging tests #54

Closed

nicoddemus deleted the logging branch June 10, 2015 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capture Qt log messages #40

Capture Qt log messages #40

nicoddemus commented Apr 27, 2015

coveralls commented Apr 27, 2015

coveralls commented Apr 27, 2015

coveralls commented Apr 29, 2015

The-Compiler Apr 29, 2015

nicoddemus Apr 29, 2015

The-Compiler Apr 30, 2015

coveralls commented Apr 29, 2015

coveralls commented Apr 29, 2015

coveralls commented Apr 30, 2015

coveralls commented Apr 30, 2015

The-Compiler Apr 30, 2015

nicoddemus Apr 30, 2015

coveralls commented Apr 30, 2015

coveralls commented May 1, 2015

coveralls commented May 1, 2015

coveralls commented May 1, 2015

The-Compiler May 7, 2015

nicoddemus May 9, 2015

nicoddemus commented Jun 6, 2015

		qtlog.messages = []


		def test_fixture_with_loggin_disabled(testdir):

Capture Qt log messages #40

Capture Qt log messages #40

Conversation

nicoddemus commented Apr 27, 2015

coveralls commented Apr 27, 2015

coveralls commented Apr 27, 2015

coveralls commented Apr 29, 2015

The-Compiler Apr 29, 2015

Choose a reason for hiding this comment

nicoddemus Apr 29, 2015

Choose a reason for hiding this comment

The-Compiler Apr 30, 2015

Choose a reason for hiding this comment

coveralls commented Apr 29, 2015

coveralls commented Apr 29, 2015

coveralls commented Apr 30, 2015

coveralls commented Apr 30, 2015

The-Compiler Apr 30, 2015

Choose a reason for hiding this comment

nicoddemus Apr 30, 2015

Choose a reason for hiding this comment

coveralls commented Apr 30, 2015

coveralls commented May 1, 2015

coveralls commented May 1, 2015

coveralls commented May 1, 2015

The-Compiler May 7, 2015

Choose a reason for hiding this comment

nicoddemus May 9, 2015

Choose a reason for hiding this comment

nicoddemus commented Jun 6, 2015