Skip to content

Commit

Permalink
Merge pull request #3401 from kohr-h/underscore_fixtures
Browse files Browse the repository at this point in the history
Mention omission of fixtures with leading '_', closes #3398
  • Loading branch information
nicoddemus committed Apr 16, 2018
2 parents 36f6687 + 6626d2a commit 159cd39
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 7 deletions.
3 changes: 2 additions & 1 deletion _pytest/helpconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ def showhelp(config):
tw.line("to see available markers type: pytest --markers")
tw.line("to see available fixtures type: pytest --fixtures")
tw.line("(shown according to specified file_or_dir or current dir "
"if not specified)")
"if not specified; fixtures with leading '_' are only shown "
"with the '-v' option")

for warningreport in reporter.stats.get('warnings', []):
tw.line("warning : " + warningreport.message, red=True)
Expand Down
3 changes: 2 additions & 1 deletion _pytest/python.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def pytest_addoption(parser):
group = parser.getgroup("general")
group.addoption('--fixtures', '--funcargs',
action="store_true", dest="showfixtures", default=False,
help="show available fixtures, sorted by plugin appearance")
help="show available fixtures, sorted by plugin appearance "
"(fixtures with leading '_' are only shown with '-v')")
group.addoption(
'--fixtures-per-test',
action="store_true",
Expand Down
1 change: 1 addition & 0 deletions changelog/3398.trivial.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Mention in documentation and CLI help that fixtures with leading ``_`` are printed by ``pytest --fixtures`` only if the ``-v`` option is added.
2 changes: 1 addition & 1 deletion doc/en/builtin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ For information on plugin hooks and objects, see :ref:`plugins`.

For information on the ``pytest.mark`` mechanism, see :ref:`mark`.

For information about fixtures, see :ref:`fixtures`. To see a complete list of available fixtures, type::
For information about fixtures, see :ref:`fixtures`. To see a complete list of available fixtures (add ``-v`` to also see fixtures with leading ``_``), type ::

$ pytest -q --fixtures
cache
Expand Down
6 changes: 3 additions & 3 deletions doc/en/fixture.rst
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ with a list of available function arguments.

.. note::

You can always issue::
You can always issue ::

pytest --fixtures test_simplefactory.py

to see available fixtures.
to see available fixtures (fixtures with leading ``_`` are only shown if you add the ``-v`` option).

Fixtures: a prime example of dependency injection
---------------------------------------------------
Expand All @@ -141,7 +141,7 @@ automatically gets discovered by pytest. The discovery of
fixture functions starts at test classes, then test modules, then
``conftest.py`` files and finally builtin and third party plugins.

You can also use the ``conftest.py`` file to implement
You can also use the ``conftest.py`` file to implement
:ref:`local per-directory plugins <conftest.py plugins>`.

Sharing test data
Expand Down
2 changes: 2 additions & 0 deletions doc/en/getting-started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ Find out what kind of builtin :ref:`pytest fixtures <fixtures>` exist with the c

pytest --fixtures # shows builtin and custom fixtures

Note that this command omits fixtures with leading ``_`` unless the ``-v`` option is added.

Continue reading
-------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion doc/en/test/plugin/terminal.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ command line options
``--full-trace``
don't cut any tracebacks (default is to cut).
``--fixtures``
show available function arguments, sorted by plugin
show available fixtures, sorted by plugin appearance (fixtures with leading ``_`` are only shown with '-v')

Start improving this plugin in 30 seconds
=========================================
Expand Down

0 comments on commit 159cd39

Please sign in to comment.