Skip to content

Commit

Permalink
Merge pull request #3360 from RonnyPfannschmidt/xml_property_yay
Browse files Browse the repository at this point in the history
record_property is no longer experimental
  • Loading branch information
nicoddemus committed Apr 5, 2018
2 parents ad0b433 + 2018cf1 commit ef34de9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
5 changes: 0 additions & 5 deletions _pytest/junitxml.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,6 @@ def record_property(request):
def test_function(record_property):
record_property("example_key", 1)
"""
request.node.warn(
code='C3',
message='record_property is an experimental feature',
)

def append_property(name, value):
request.node.user_properties.append((name, value))
return append_property
Expand Down
2 changes: 2 additions & 0 deletions changelog/3360.trivial
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
record_property is no longer experimental, removing the warnings was forgotten.

6 changes: 1 addition & 5 deletions testing/test_junitxml.py
Original file line number Diff line number Diff line change
Expand Up @@ -868,17 +868,13 @@ def other(record_property):
def test_record(record_property, other):
record_property("foo", "<1");
""")
result, dom = runandparse(testdir, '-rw')
result, dom = runandparse(testdir, '-rwv')
node = dom.find_first_by_tag("testsuite")
tnode = node.find_first_by_tag("testcase")
psnode = tnode.find_first_by_tag('properties')
pnodes = psnode.find_by_tag('property')
pnodes[0].assert_attr(name="bar", value="1")
pnodes[1].assert_attr(name="foo", value="<1")
result.stdout.fnmatch_lines([
'test_record_property.py::test_record',
'*record_property*experimental*',
])


def test_record_property_same_name(testdir):
Expand Down

0 comments on commit ef34de9

Please sign in to comment.