pytest.deprecated_call doesn't catch PendingDeprecationWarnings

[alex]

In 2.7.3 it did, but now it doesn't.

[hpk42]

i tried for 5 minutes or so to reproduce the failing test suite but ran into problems. Could you provide an example of what goes wrong, at the least provide a link to a failed test run with 2.8 that worked with 2.7.3?

[alex]

(tempenv-079b216902410) ~/.v/tempenv-079b216902410 $ pip install pytest==2.7.3
Collecting pytest==2.7.3
  Using cached pytest-2.7.3-py2.py3-none-any.whl
Collecting py>=1.4.29 (from pytest==2.7.3)
  Using cached py-1.4.30-py2.py3-none-any.whl
Installing collected packages: py, pytest
Successfully installed py-1.4.30 pytest-2.7.3
(tempenv-079b216902410) ~/.v/tempenv-079b216902410 $ py.test t.py
====================================================== test session starts =======================================================
platform darwin -- Python 2.7.10 -- py-1.4.30 -- pytest-2.7.3
rootdir: /Users/vacogaynoa/.virtualenvs/tempenv-079b216902410, inifile:
collected 1 items

t.py .

==================================================== 1 passed in 0.00 seconds ====================================================
(tempenv-079b216902410) ~/.v/tempenv-079b216902410 $ pip install -U pytest
Collecting pytest
  Using cached pytest-2.8.0-py2.py3-none-any.whl
Requirement already up-to-date: py>=1.4.29 in ./lib/python2.7/site-packages (from pytest)
Installing collected packages: pytest
  Found existing installation: pytest 2.7.3
    Uninstalling pytest-2.7.3:
      Successfully uninstalled pytest-2.7.3
Successfully installed pytest-2.8.0
(tempenv-079b216902410) ~/.v/tempenv-079b216902410 $ py.test t.py
====================================================== test session starts =======================================================
platform darwin -- Python 2.7.10, pytest-2.8.0, py-1.4.30, pluggy-0.3.1
rootdir: /Users/vacogaynoa/.virtualenvs/tempenv-079b216902410, inifile:
collected 1 items

t.py F

============================================================ FAILURES ============================================================
_____________________________________________________________ test_f _____________________________________________________________

    def test_f():
>       pytest.deprecated_call(f)
E       AssertionError: <function f at 0x106ce7410> did not produce DeprecationWarning

t.py:11: AssertionError
------------------------------------------------------ Captured stderr call ------------------------------------------------------
/Users/vacogaynoa/.virtualenvs/tempenv-079b216902410/t.py:7: PendingDeprecationWarning: msg
  warnings.warn('msg', PendingDeprecationWarning)
==================================================== 1 failed in 0.00 seconds ====================================================
(tempenv-079b216902410) ~/.v/tempenv-079b216902410 $ cat t.py
import warnings

import pytest


def f():
    warnings.warn('msg', PendingDeprecationWarning)


def test_f():
    pytest.deprecated_call(f)

[hpk42]

thanks. the offending commit seems to be 52b4eb6 -- maybe @hunse can take a look?

[hunse]

Okay, I've got a fix.