Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop python 2.6 support when pip does #1273

Closed
RonnyPfannschmidt opened this issue Dec 22, 2015 · 18 comments
Closed

drop python 2.6 support when pip does #1273

RonnyPfannschmidt opened this issue Dec 22, 2015 · 18 comments
Assignees
@RonnyPfannschmidt
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: deprecation feature that will be removed in the future type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Milestone
3.3

Comments

@RonnyPfannschmidt
Copy link
Member

python 2.6 is eol since a while now - if people want to stay on old version they can pin py.test 2.8
@RonnyPfannschmidt RonnyPfannschmidt added type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog labels Dec 22, 2015
@RonnyPfannschmidt RonnyPfannschmidt added this to the 2.9 milestone Dec 22, 2015
@nicoddemus
Copy link
Member

Some blog posts related:

@nicoddemus
Copy link
Member

Perhaps it would be nice to post a link to the mailing list to gather feedback? I don't have a clear idea of how many users still only use 2.6.

One thing I've missed when working on py.test is dict comprehensions and set literals... other than that I have not hit any major roadblocks, so I'm +0 on the idea.

@flub
Copy link
Member

flub commented Jan 1, 2016

Other then one less version to test for, is there anything which is gained
from dropping 2.6? If there's a specific patch/feature which struggles
with 2.6 support then it makes sense to drop for me, but if not I'm
probably -0
On 22 Dec 2015 13:14, "Bruno Oliveira" notifications@github.com wrote:

Perhaps it would be nice to post a link to the mailing list to gather
feedback? I don't have a clear idea of how many users still only use 2.6.

One thing I've missed when working on py.test is dict comprehensions and
set literals... other than that I have not hit any major roadblocks, so I'm
+0 on the idea.

—
Reply to this email directly or view it on GitHub
#1273 (comment).

@RonnyPfannschmidt
Copy link
Member Author

We have a few 2.6 only bugs and 2.6 is eol

Also 2.6 prevented details like pytest as a package

@nicoddemus
Copy link
Member

To me pinning 2.6 for projects which depend on that seems reasobable...

@RonnyPfannschmidt
Copy link
Member Author

twitter feedback seems positive, what other channels should i stir up?

@nicoddemus
Copy link
Member

I would send an email to the mailing list

@RonnyPfannschmidt
Copy link
Member Author

closing after crosschecking with pip

@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Jan 5, 2016
Closed
@nicoddemus
Copy link
Member

closing after crosschecking with pip

What do you mean @RonnyPfannschmidt?

@RonnyPfannschmidt
Copy link
Member Author

pip tries to follow pytest latest and will support python 2.6 in the 7 series and possibly in the 8 series

@nicoddemus
Copy link
Member

So in conclusion, we will follow pip's lead here, and drop 2.6 when they also drop it?

@nicoddemus
Copy link
Member

Oh sorry, I just now saw #1308... sorry for the noise

@nicoddemus
Copy link
Member

I think we should re-open this, because we will eventually drop 2.6. We should just rename it to make it clear that we are following pip's lead on this ("Drop python 2.6 support after pip does the same" or something like that).

Creating a new one is also valid, but I think re-using this would be better because it will keep the history of this conversation.

@RonnyPfannschmidt RonnyPfannschmidt changed the title drop python 2.6 support in the next feature release drop python 2.6 support when pip does Jan 5, 2016
@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Jan 5, 2016
@The-Compiler The-Compiler removed this from the 2.9 milestone Feb 26, 2016
@The-Compiler
Copy link
Member

Removing the 2.9 milestone as we agreed to postpone this until pip drops 2.6

@nicoddemus
Copy link
Member

We're close: pypa/pip#4343 has been merged. I suppose pip 10.0 will drop it. 👍

@nicoddemus
Copy link
Member

Dropping 2.6 support would warrant a pytest-4.0 release?

@RonnyPfannschmidt
Copy link
Member Author

i think so

@nicoddemus nicoddemus mentioned this issue Jul 26, 2017
Merged
4 tasks
@nicoddemus nicoddemus added the type: deprecation feature that will be removed in the future label Aug 1, 2017
@nicoddemus
Copy link
Member

Fixed in #2822

@nicoddemus nicoddemus added this to the 3.3 milestone Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RonnyPfannschmidt RonnyPfannschmidt

Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: deprecation feature that will be removed in the future type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
4 participants
@flub @RonnyPfannschmidt @The-Compiler @nicoddemus