Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py27-trial and py35-trial environments failures on Travis and AppVeyor #1989

Closed
The-Compiler opened this Issue Oct 5, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@The-Compiler
Copy link
Member

The-Compiler commented Oct 5, 2016

See e.g. https://travis-ci.org/pytest-dev/pytest/jobs/165320324:

____________________ test_trial_testfunction_todo_property _____________________
testdir = <Testdir local('/tmp/pytest-of-travis/pytest-0/testdir/test_trial_testfunction_todo_property0')>
    def test_trial_testfunction_todo_property(testdir):
>       pytest.importorskip('twisted.trial.unittest')
/home/travis/build/pytest-dev/pytest/testing/test_unittest.py:353: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/home/travis/build/pytest-dev/pytest/.tox/py35-trial/lib/python3.5/site-packages/twisted/trial/unittest.py:12: in <module>
    from twisted.trial._synctest import (
/home/travis/build/pytest-dev/pytest/.tox/py35-trial/lib/python3.5/site-packages/twisted/trial/_synctest.py:23: in <module>
    from twisted.trial import itrial, util
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
    """

    from __future__ import division, absolute_import

>   import zope.interface as zi
E   AttributeError: module 'zope' has no attribute 'interface'
@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Oct 5, 2016

Thanks! I meant to take a look in #1979 but didn't have the time, so opening an issue is better.

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Oct 13, 2016

I investigated this for some time today and here's what I found so far:

  1. It doesn't depend on pytest's version.

  2. It doesn't happen in python 3.4.

  3. It can be reproduced with:

    $ pytest test_unittest.py::test_trial_testfunction_skip_property test_unittest.py::test_trial_testcase_skip_property
    

    This command makes the second test to fail. Changing the order of the tests again makes the second to fail.

Those tests execute a trial TestCase in-process so I think that's the cause although I don't know what is the actual problem.

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Oct 20, 2016

RonnyPfannschmidt added a commit that referenced this issue Oct 20, 2016

Merge pull request #2018 from nicoddemus/disable-py35-trial
Disable py35-trial while #1989 is not fixed

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Nov 11, 2016

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Nov 11, 2016

@sebastinas

This comment has been minimized.

Copy link
Contributor

sebastinas commented Nov 16, 2016

We have also seen this issue with Python 2.7 in Debian recently. See https://tests.reproducible-builds.org/debian/rbuild/unstable/i386/pytest_3.0.3-1.rbuild.log for a log.

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Dec 26, 2016

More information: this started to fail on AppVeyor as well, including py27-trial. 😟

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Dec 26, 2016

Allow trial environments to fail on CI for now
While I agree this is *far* from ideal, IMHO It is better to ignore them for now otherwise we hamper contributors with unrelated errors.

We should fix this before the next release.

pytest-dev#1989

@nicoddemus nicoddemus changed the title py35-trial fails on Travis py27-trial and py35-trial environments failures on Travis and AppVeyor Jan 6, 2017

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Jan 19, 2017

This was referenced Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.