New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure compat properties trigger DeprecationWarnings #2034

Closed
RonnyPfannschmidt opened this Issue Oct 31, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@RonnyPfannschmidt
Member

RonnyPfannschmidt commented Oct 31, 2016

https://github.com/pytest-dev/pytest/blob/master/_pytest/main.py#L191

should do a warnings.warn so we can safely remove later on

@lwm

This comment has been minimized.

Contributor

lwm commented Nov 26, 2016

Is there some policy on adding these warnings (ala Django's deprecation docs)?

Maybe not important on this one in particular ...

@nmundar

This comment has been minimized.

Contributor

nmundar commented Nov 26, 2016

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Nov 26, 2016

Is there some policy on adding these warnings (ala Django's deprecation docs)?

Our policy is written here: http://doc.pytest.org/en/latest/backwards-compatibility.html

It is very recent though so we are still maturing it.

@lwm

This comment has been minimized.

Contributor

lwm commented Nov 26, 2016

Oh, nice one, thanks for passing that link @nicoddemus!

nicoddemus added a commit to nmundar/pytest that referenced this issue Nov 27, 2016

nicoddemus added a commit to nmundar/pytest that referenced this issue Nov 27, 2016

nicoddemus added a commit to nmundar/pytest that referenced this issue Nov 27, 2016

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Nov 27, 2016

Fixed by #2088

This was referenced Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment