Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure compat properties trigger DeprecationWarnings #2034

Closed
RonnyPfannschmidt opened this issue Oct 31, 2016 · 5 comments
Closed

ensure compat properties trigger DeprecationWarnings #2034

RonnyPfannschmidt opened this issue Oct 31, 2016 · 5 comments

Comments

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Oct 31, 2016

https://github.com/pytest-dev/pytest/blob/master/_pytest/main.py#L191

should do a warnings.warn so we can safely remove later on

@decentral1se
Copy link
Contributor

@decentral1se decentral1se commented Nov 26, 2016

Is there some policy on adding these warnings (ala Django's deprecation docs)?

Maybe not important on this one in particular ...

@nmundar
Copy link
Contributor

@nmundar nmundar commented Nov 26, 2016

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 26, 2016

Is there some policy on adding these warnings (ala Django's deprecation docs)?

Our policy is written here: http://doc.pytest.org/en/latest/backwards-compatibility.html

It is very recent though so we are still maturing it.

@decentral1se
Copy link
Contributor

@decentral1se decentral1se commented Nov 26, 2016

Oh, nice one, thanks for passing that link @nicoddemus!

nicoddemus added a commit to nmundar/pytest that referenced this issue Nov 27, 2016
nicoddemus added a commit to nmundar/pytest that referenced this issue Nov 27, 2016
nicoddemus added a commit to nmundar/pytest that referenced this issue Nov 27, 2016
@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 27, 2016

Fixed by #2088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants