Issue 2034

[nmundar]

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

• Target: for bug or doc fixes, target master; for new features, target features;

Unless your change is trivial documentation fix (e.g., a typo or reword of a small section) please:

• Make sure to include one or more tests for your change;
• Add yourself to AUTHORS;
• Add a new entry to CHANGELOG.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using RST syntax.
  • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

[coveralls]

Coverage increased (+0.002%) to 92.821% when pulling c919ab6 on nmundar:issue-2034 into 33796c8 on pytest-dev:master.

[nicoddemus]

This should be: "compatproperty is deprecated. Use pytest.{0}".format(name)

[nicoddemus]

Hmmm actually this probably should be:

"this usage is deprecated, please use pytest.{0} instead".format(name)" because I'm not sure of all cases this is deprecating.

[nicoddemus]

Please add the name of the property to the deprecation message.

[nicoddemus]

Thanks!

[nicoddemus]

Also please rebase on master.

[nmundar]

Argh, sorry for the typo in the commit message!

[coveralls]

Coverage increased (+0.0008%) to 92.82% when pulling 7e0c462 on nmundar:issue-2034 into 33796c8 on pytest-dev:master.

[nicoddemus]

Feel free to amend it. I just noticed that the CHANGELOG message could also mention that what's being deprecated is accessing item.Function, item.Module, etc. If you amend the commit could you update the CHANGELOG as well? If not, don't worry about it, I can do it later

…

On Sat, Nov 26, 2016, 18:40 Neven Munđar ***@***.***> wrote: Argh, sorry for the typo in the commit message! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2088 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCO_NTP4ILE8PRt3Rc2yTdwjvAH-Oevks5rCJlQgaJpZM4K837e> .

[nmundar]

Please, if it's not a bother, update the changelog as you see fit, you have a better idea about wording. Don't want to mess up, the same with force pushing amended commits.

[nicoddemus]

Sure, I will do it before merging, thanks!

…

On Sat, Nov 26, 2016, 19:06 Neven Munđar ***@***.***> wrote: Please, if it's not a bother, update the changelog as you see fit, you have a better idea about wording. Don't want to mess up, the same with force pushing amended commits. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2088 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCO_PK_KJkdGdcGnIdIylRXBYhJJkvEks5rCJ9FgaJpZM4K837e> .

[nicoddemus]

Updated CHANGELOG and rebased on master. Forced push to the branch in your fork @nmundar, hope you don't mind.

[coveralls]

Coverage increased (+0.002%) to 92.82% when pulling 2d71979 on nmundar:issue-2034 into 4837542 on pytest-dev:master.

[coveralls]

Coverage increased (+0.002%) to 92.82% when pulling 2d71979 on nmundar:issue-2034 into 4837542 on pytest-dev:master.