Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixture hooks use session.ihook instead of a fitting hookproxy #2124

Closed
RonnyPfannschmidt opened this issue Dec 8, 2016 · 1 comment
Closed

fixture hooks use session.ihook instead of a fitting hookproxy #2124

RonnyPfannschmidt opened this issue Dec 8, 2016 · 1 comment
Labels
topic: fixtures anything involving fixtures directly or indirectly type: bug problem that needs to be addressed

Comments

@RonnyPfannschmidt
Copy link
Member

just realized this after reviewing the FixtureDef.execute method after a user reported trouble with getting the fixture setup hooks called from conftests/test files
malinoff added a commit to malinoff/pytest that referenced this issue Dec 10, 2016
@malinoff
Use session.config.hook instead of ihook. Fixes pytest-dev#2124
522d59e
@nicoddemus nicoddemus added topic: fixtures anything involving fixtures directly or indirectly type: bug problem that needs to be addressed labels Sep 29, 2017
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Nov 12, 2017
@nicoddemus
Add changelog entries for pytest-dev#2124
063335a
nicoddemus added a commit that referenced this issue Nov 12, 2017
@nicoddemus
Merge pull request #2127 from malinoff/fix-2124
685387a 
Use session.config.hook instead of ihook. Fixes #2124
@nicoddemus
Copy link
Member

Fixed by #2127

@pytestbot pytestbot mentioned this issue May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: fixtures anything involving fixtures directly or indirectly type: bug problem that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RonnyPfannschmidt @nicoddemus