/pytest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixture hooks use session.ihook instead of a fitting hookproxy #2124

Closed
RonnyPfannschmidt opened this Issue Dec 8, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@RonnyPfannschmidt @nicoddemus
@RonnyPfannschmidt
Member

RonnyPfannschmidt commented Dec 8, 2016

just realized this after reviewing the FixtureDef.execute method after a user reported trouble with getting the fixture setup hooks called from conftests/test files

malinoff added a commit to malinoff/pytest that referenced this issue Dec 10, 2016

@malinoff
Use session.config.hook instead of ihook. Fixes pytest-dev#2124
522d59e

@nicoddemus nicoddemus added topic: fixtures type: bug labels Sep 29, 2017

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Nov 12, 2017

@nicoddemus
Add changelog entries for pytest-dev#2124
063335a

nicoddemus added a commit that referenced this issue Nov 12, 2017

@nicoddemus
Merge pull request #2127 from malinoff/fix-2124 
Use session.config.hook instead of ihook. Fixes #2124
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
685387a
@nicoddemus

This comment has been minimized.

Sign in to view
Member

nicoddemus commented Nov 12, 2017

Fixed by #2127

@nicoddemus nicoddemus closed this Nov 12, 2017

@pytestbot pytestbot referenced this issue May 10, 2018

Closed

Use an automatic code formatter and pre-commit hook? #3464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment