Test report text issue

[hackebrot]

Hi! 👋

I'm working off the features branch right now and noticed that the test output reads:

collected 1 item s

tests/test_helloworld.py .

Looks like we have tiny issue with item s 😁

/cc @flub

[nicoddemus]

Should have been fixed by #2571... are you still seeing this even after it?

[hackebrot]

I just cherry-picked the commit from the bugfix PR. Looks like it's still showing the extra space, but only if a single test is collected

def test_helloworld():
    assert "Hello"

$ pytest test_unwanted_space.py

collected 1 item s

test_unwanted_space.py .

[hackebrot]

I'm writing a test for it. 👍

[hackebrot]

Can't get my unittest for the bug to fail. Most probably because pytester works differently than if you run pytest from the CLI 😢

[RonnyPfannschmidt]

i suspect it will be hard to test unless we run pytest against a pty and a terminal emulator

[asottile]

Here's a screenshot from my dupe bug report:

[asottile]

From some testing, the "rewrite" needs to overwrite the entire previous line:

$ echo -e 'hello\rhi'
hillo
$ echo -e 'hello     \rhi'
hillo     
$ echo -e 'hello\r     \rhi'
hi   
$ echo -e 'hello     \rhi'
hillo     
$ echo -e 'hello\r     \rhi'
hi   
$ echo -e 'hello\r\rhi'
hillo

this SO post implies there's a better solution but I'm unsure how portable it is...

[RonnyPfannschmidt]

vt100 has escape codes to do stuff like clearing lines, i believe colorama ports those to windows

[RonnyPfannschmidt]

but this has to be fixed in pylib

i should note that terminalwriter is fairly aged, i wish we could remove it, but people depend on it too much :/

[hackebrot]

Thank you for looking into this @nicoddemus @RonnyPfannschmidt! 🙇