Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure final collected line doesn't include artifacts of previous write #2571

Merged
merged 1 commit into from Jul 13, 2017

Conversation

@ahartoto
Copy link
Contributor

@ahartoto ahartoto commented Jul 13, 2017

We sometimes would see the following line:
collected 1 item s

just because previous write to the terminal includes number of characters greater than 'collected 1 item'.

We sometimes would see the following line:
collected 1 item s

just because previous write to the terminal includes number of
characters greater than 'collected 1 item'.
@coveralls
Copy link

@coveralls coveralls commented Jul 13, 2017

Coverage Status

Coverage increased (+0.0009%) to 92.128% when pulling 97fdc9a on ahartoto:master into 771cedd on pytest-dev:master.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

@ahartoto looks good, thanks - i wonder if there is a reasonable way to test this (i suspect the effordt is higher than acceptable and we should merge without)

@nicoddemus any idea whats up with appevoyer on this one?

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jul 13, 2017

I didn't quite understand the issue TBH, sorry. @ahartoto could you please post the full output you get and explain in a little more detail what's the problem?

any idea whats up with appevoyer on this one?

Not sure... we could try pushing again and see what happens?

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Jul 13, 2017

@nicoddemus i experienced similar issues - see the final item s the s shouldn't be there

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jul 13, 2017

i experienced similar issues - see the final item s the s shouldn't be there

Hmm yeah I noticed it, just wondering in which situations that might happen (I'm just trying to understand the issue that's all, nothing against the patch).

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Jul 13, 2017

when against all expectations only a single test is collected, then the output on its own isn't wide enough to overwrite the prior existing characters

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jul 13, 2017

OH sorry, just tried it myself and the problem is pretty obvious! 😅

collected 1 item s

Sorry about that, I could swear I have tried this before and it showed correctly "collected 1 item", that's why I was confused about the problem. 👍

Sorry about all the noise!

@RonnyPfannschmidt RonnyPfannschmidt merged commit 3578f4e into pytest-dev:master Jul 13, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahartoto
Copy link
Contributor Author

@ahartoto ahartoto commented Jul 14, 2017

Sorry for the late response. This is probably what happened. pytest printed:
collecting 0 items

Then went to:
collected 1 item

If we overlay them, we would see:
collected 1 item s

That's what happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants