Ensure final collected line doesn't include artifacts of previous write

[ahartoto]

We sometimes would see the following line:
collected 1 item s

just because previous write to the terminal includes number of characters greater than 'collected 1 item'.

[coveralls]

Coverage increased (+0.0009%) to 92.128% when pulling 97fdc9a on ahartoto:master into 771cedd on pytest-dev:master.

[RonnyPfannschmidt]

@ahartoto looks good, thanks - i wonder if there is a reasonable way to test this (i suspect the effordt is higher than acceptable and we should merge without)

@nicoddemus any idea whats up with appevoyer on this one?

[nicoddemus]

I didn't quite understand the issue TBH, sorry. @ahartoto could you please post the full output you get and explain in a little more detail what's the problem?

any idea whats up with appevoyer on this one?

Not sure... we could try pushing again and see what happens?

[RonnyPfannschmidt]

@nicoddemus i experienced similar issues - see the final item s the s shouldn't be there

[nicoddemus]

i experienced similar issues - see the final item s the s shouldn't be there

Hmm yeah I noticed it, just wondering in which situations that might happen (I'm just trying to understand the issue that's all, nothing against the patch).

[RonnyPfannschmidt]

when against all expectations only a single test is collected, then the output on its own isn't wide enough to overwrite the prior existing characters

[nicoddemus]

OH sorry, just tried it myself and the problem is pretty obvious! 😅

collected 1 item s

Sorry about that, I could swear I have tried this before and it showed correctly "collected 1 item", that's why I was confused about the problem. 👍

Sorry about all the noise!

[ahartoto]

Sorry for the late response. This is probably what happened. pytest printed:
collecting 0 items

Then went to:
collected 1 item

If we overlay them, we would see:
collected 1 item s

That's what happened.