Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger deprecation warning for py.test cli command #2993

Closed
RonnyPfannschmidt opened this issue Dec 2, 2017 · 3 comments
Closed

trigger deprecation warning for py.test cli command #2993

RonnyPfannschmidt opened this issue Dec 2, 2017 · 3 comments
Labels
plugin: warnings related to the warnings builtin plugin type: deprecation feature that will be removed in the future

Comments

@RonnyPfannschmidt
Copy link
Member

we provide a dropthedot variant since a good while now, in order to support the transition we should trigger a deprecationwarning

@RonnyPfannschmidt RonnyPfannschmidt added the type: deprecation feature that will be removed in the future label Dec 2, 2017
@nicoddemus nicoddemus added the plugin: warnings related to the warnings builtin plugin label Aug 10, 2018
@nicoddemus
Copy link
Member

TBH I don't think we should deprecate/remove py.test at all, for the reason that it is not a maintenance burden for us (1 line of code), and removing it will break old scripts without a good reason.

IMHO we should deprecate/remove old implementations/APIs that are:

  1. A maintenance burden for us;
  2. Bad practices (message parameter of pytest.raises);
  3. Confusing terminology (getfuncargvalue vs getfixturevalue).

It doesn't really matter if users use py.test in old scripts after all. We just recommend the new pytest command in the docs, and that's it.

Same goes for yield_fixture IMO.

What do you think?

@blueyed
Copy link
Contributor

blueyed commented Dec 15, 2018

I agree with @nicoddemus.
py.test is still used a lot.

@Zac-HD
Copy link
Member

Zac-HD commented Jun 24, 2019

Closing this as wontfix; while we all prefer the new form there's little to gain from deprecating the old.

@Zac-HD Zac-HD closed this as completed Jun 24, 2019
altendky added a commit to altendky/pytest-timeout that referenced this issue May 16, 2020
pytest-dev/pytest#2993

Not making a fuss, just one of two things I noticed reading the readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: warnings related to the warnings builtin plugin type: deprecation feature that will be removed in the future
Projects
None yet
Development

No branches or pull requests

4 participants