Make --ignore flag work with --pyargs

[rth]

I just discovered the --pyargs option and it's very practical. However it does not seem to take into account the --ignore options.

Example,

$ pytest --doctest-modules  --pyargs setuptools
============================================ test session starts ============================================
platform linux -- Python 3.6.4, pytest-3.4.1, py-1.5.2, pluggy-0.6.0
rootdir: /home/rth, inifile:
plugins: profiling-1.2.11
collected 6 items                                                                                           

anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/namespaces.py .                       [ 16%]
anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/package_index.py .                    [ 33%]
anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/sandbox.py .                          [ 50%]
anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/command/develop.py .                  [ 66%]
anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/command/install_lib.py .              [ 83%]
anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/command/py36compat.py .               [100%]

========================================= 6 passed in 0.52 seconds ==========================================

running,

pytest --doctest-modules --ignore develop.py  --pyargs setuptools

produces exactly identical output, while I would have expected the develop.py not to be tested.
Here is another example of this same issue.

Is there a way around it?

[nicoddemus]

Hi @rth,

--ignore only checks for paths and does not currently work with --pyargs, but I guess it could be made to work with it.

[rth]

Thanks for the confirmation, @nicoddemus !

Providing the full path to --ignore, in my case

anaconda2/envs/testn-env/lib/python3.6/site-packages/setuptools/command/develop.py

does work even for --pyargs.

I'm wondering if this couldn't be solved by just adding support for regexp in --ignore. This is also something that might be nice to have independently of this issue, I think.

As far as I can tell all --pyargs does is to finding the full path path to the package here.
And roughly speaking, if one were to replace,

pytest/_pytest/main.py

Line 187 in e980fbb

if py.path.local(path) in ignore_paths:

by

if re.match(py.path.local(path), ' '.join(ignore_paths))

(or something based on fnmatch) it could work, I imagine.

Would this feature be acceptable for pytest? Am I missing something? To avoid breaking backward compatibility fnmatch might be better, but even then I'm not sure this wouldn't break existing setups...

[rth]

To avoid breaking backward compatibility fnmatch might be better, but even then I'm not sure this wouldn't break existing setups...

Or maybe add another CLI option similar to --ignore but for regexp, e.g. --ignore-regexp ...

[nicoddemus]

Would this feature be acceptable for pytest? Am I missing something? To avoid breaking backward compatibility fnmatch might be better, but even then I'm not sure this wouldn't break existing setups...

Seems reasonable, and if we use re.search instead of re.match we probably won't even break backward compatibility.

[ngie-eign]

I was wondering why this functionality didn't work as expected. I am using 4.6.x (2.7) and 6.2.x (3.x).
I'm curious... rhetorically speaking, why aren't paths being ignored after the package(s) have been imported? Seems backwards to apply it beforehand and only in select cases.