get_marker doesn't work for parametrized tests using custom markers

[petr-balogh]

When we are using parametrize regarding to doc and in pytest hook pytest_collection_modifyitems we would like to get marker and it's value we are failing with error:
ValueError: MarkInfo expects Mark instances, got MarkDecorator(mark=Mark(name='custom_mark', args=('custom mark1',), kwargs={})) (<class '_pytest.mark.structures.MarkDecorator'>)

How to reproduce:
I attached full example,, you just need to run_test.sh script.

• requirement file is part of attached examle, contains just latest pytest@features branch
• latest - features branch
• Minimal example if possible, attached pytest_marker_issue.tar.gz

test_file.py:

import pytest

first_custom_mark = pytest.mark.custom_marker
custom_mark = pytest.mark.custom_mark

@custom_mark("custom mark non parametrized")
def test_custom_mark_non_parametrized():
    print "Hey from test"

@pytest.mark.parametrize(
    "obj_type",
    [
        first_custom_mark("first custom mark")("template"),
        pytest.param( # Think this should be recommended way?
            "disk",
            marks=custom_mark('custom mark1')
        ),
        custom_mark("custom mark2")("vm"),  # Tried also this
    ]
)
def test_custom_mark_parametrized(obj_type):
    print "obj_type is: %s" % obj_type

conftest.py

def pytest_collection_modifyitems(session, config, items):
    for item in items:
        # here we are failing with:
        # INTERNALERROR> ValueError: MarkInfo expects Mark instances, got
        # MarkDecorator(mark=Mark(name='custom_mark', args=('custom mark1',), kwargs={})) (<class '_pytest.mark.structures.MarkDecorator'>)
        custom_mark = item.get_marker('custom_mark')
        print("Custom mark %s" % custom_mark)

[pytestbot]

GitMate.io thinks possibly related issues are #1697 (Fixture scope doesn't work when it is parametrized), #2133 (Pytest.mark doesn't work on a list of markers as suggested in the documentation), #379 (Can't not apply multiple markers to individual test when using parametrize), #396 (Class scope in parametrized fixtures does not work if first class to be collected has only one method using that fixture), and #1601 (Overriding autouse fixture with a parametrized fixture does not work).

[petr-balogh]

This bug was introduced in version 3.6.2, I've just tested with 3.6.1 and here it's working well.

[RonnyPfannschmidt]

i introduced it fixing another one, ill investigate tommorow

[petr-balogh]

Thanks

[RonnyPfannschmidt]

ps - i believe i missed to add a unpacking while making the internals more strict, so the code is already broken from before, now it just actually shows instead of silently hiding it

[RonnyPfannschmidt]

i transformed your post into a fialing test i believe i will find a nice solution tommorow

[petr-balogh]

Thanks Ronny for the effort. Please, just a question about usage of multiple markers cause we want also use it. Is there any known issue at the moment? Or will it also work with multiple marks? Like:

pytest.param( # Think this should be recommended way?
            "disk",
            marks=(custom_mark('custom mark1'), custo_mark2('custom mark2'))
        ),
# Or like this?:
first_custom_mark("first custom mark")(second_custom_mark('second custom mark'))("template"),

[RonnyPfannschmidt]

@petr-balogh the ´pytest.param´ version is supposed to be the correct one, however the mark shift towards correct internals has some fallout due to a incomplete test-suite

#3606 fixes the issue you see

[Midnighter]

Hitting the same issue in combination with pytest-raises. Here's is an example of the parametrization:

@pytest.mark.parametrize("model", [
    pytest.param("missing_energy_partner",
                 marks=pytest.mark.raises(exception=ZeroDivisionError)),
    pytest.param("infeasible",
                 marks=pytest.mark.raises(exception=Infeasible))
], indirect=["model"])

[RonnyPfannschmidt]

@Midnighter the fix was not yet released

[Midnighter]

Sorry, meant to write I look forward to the fix 😃