New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug with the 3.10.0 release #4304

Closed
fzarifian opened this Issue Nov 4, 2018 · 14 comments

Comments

Projects
None yet
5 participants
@fzarifian
Contributor

fzarifian commented Nov 4, 2018

Hello,

Something went wrong with the 3.10.0 release

   ============================= test session starts ==============================
    platform linux2 -- Python 2.7.12, pytest-3.10.0, py-1.7.0, pluggy-0.8.0
    rootdir: /builds/ansible-roles/json-inventory/molecule/default, inifile:
    plugins: testinfra-1.16.0
    collecting ... 
collected 3 items                                                              
    
Traceback (most recent call last):
  File "/usr/local/bin/py.test", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 76, in main
    return config.hook.pytest_cmdline_main(config=config)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/main.py", line 218, in pytest_cmdline_main
    return wrap_session(config, _main)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/main.py", line 211, in wrap_session
    session=session, exitstatus=session.exitstatus
  File "/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/terminal.py", line 627, in pytest_sessionfinish
    outcome.get_result()
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/stepwise.py", line 102, in pytest_sessionfinish
    self.config.cache.set("cache/stepwise", [])
AttributeError: 'Config' object has no attribute 'cache'

The same nine hours ago with the 3.9.3 release :

    ============================= test session starts ==============================
    platform linux2 -- Python 2.7.12, pytest-3.9.3, py-1.7.0, pluggy-0.8.0
    rootdir: /builds/ansible-roles/json-inventory/molecule/default, inifile:
    plugins: testinfra-1.16.0
    
collecting 0 items                                                             
collecting 3 items                                                             
collected 3 items                                                              
    
    tests/test_default.py ...                                                [100%]
    
    =============================== warnings summary ===============================
    /usr/lib/python2.7/dist-packages/cryptography/x509/__init__.py:32
      /usr/lib/python2.7/dist-packages/cryptography/x509/__init__.py:32: PendingDeprecationWarning: CRLExtensionOID has been renamed to CRLEntryExtensionOID
        from cryptography.x509.oid import (
    
    -- Docs: https://docs.pytest.org/en/latest/warnings.html
    ==================== 3 passed, 1 warnings in 38.20 seconds =====================

If someone have an idea ? ;)

@fzarifian

This comment has been minimized.

Contributor

fzarifian commented Nov 4, 2018

PR #4297 with PR #4147 ?

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Nov 4, 2018

did you by chance disable the cache plugin?

@fzarifian

This comment has been minimized.

Contributor

fzarifian commented Nov 4, 2018

NOT OK, tested with a pytest.ini file located at the rootdir containing :

[pytest]
addopts = -p no:cacheprovider

And I get this :

--> Executing Testinfra tests found in /builds/ansible-roles/postgresql_server/molecule/default/tests/...
    ============================= test session starts ==============================
    platform linux2 -- Python 2.7.12, pytest-3.10.0, py-1.7.0, pluggy-0.8.0
    rootdir: /builds/ansible-roles/postgresql_server/molecule/default, inifile: pytest.ini
    plugins: testinfra-1.16.0
    collecting ... 
collected 2 items                                                              
    
Traceback (most recent call last):
  File "/usr/local/bin/py.test", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 76, in main
    return config.hook.pytest_cmdline_main(config=config)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/main.py", line 218, in pytest_cmdline_main
    return wrap_session(config, _main)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/main.py", line 211, in wrap_session
    session=session, exitstatus=session.exitstatus
  File "/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py", line 284, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 67, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 61, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 203, in _multicall
    gen.send(outcome)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/terminal.py", line 627, in pytest_sessionfinish
    outcome.get_result()
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/stepwise.py", line 102, in pytest_sessionfinish
    self.config.cache.set("cache/stepwise", [])
AttributeError: 'Config' object has no attribute 'cache'
    tests/test_default.py ..                                                 [100%]
An error occurred during the test sequence action: 'verify'. Cleaning up.

For me, disabling the cache plugin (like i found on the documentation) doesn't work...

Another information : the runner is a docker ubuntu16.04 built like this :

FROM ubuntu:16.04

RUN echo "# Installing apt repositories..."
    && echo "## Ansible APT Packages" \
    && apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 7BB9C367 \
    && add-apt-repository "deb [arch=amd64] http://ppa.launchpad.net/ansible/ansible/ubuntu xenial main" \
    && apt-get update -yq \
    && DEBIAN_FRONTEND=noninteractive apt-get -y install ansible python-pip

RUN echo "## Install python requirements" \
    && pip install pytest molecule docker
@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Nov 4, 2018

this is a "regression" - the stepwise plugin must be disabled as well in as it depending on the cache plugin"

fzarifian added a commit to fzarifian/pytest that referenced this issue Nov 4, 2018

@fzarifian fzarifian referenced this issue Nov 4, 2018

Open

Update __init__.py #1

0 of 6 tasks complete
@jsf9k

This comment has been minimized.

jsf9k commented Nov 5, 2018

FWIW, I'm seeing this too with version 3.10.0 when running molecule test against some of my Ansible roles. See, for instance, dhs-ncats/ansible-role-htop.

@fzarifian

This comment has been minimized.

Contributor

fzarifian commented Nov 5, 2018

@jsf9k as mentionned by @RonnyPfannschmidt, you should unregister pytest module with a file in your repository like "molecule/default/pytest.ini" like this one.

[pytest]
addopts = -p no:cacheprovider -p no:stepwise
@fzarifian

This comment has been minimized.

Contributor

fzarifian commented Nov 5, 2018

Or use like I do in your requirements.txt :

pytest==3.9.3

@amustafa

This comment has been minimized.

amustafa commented Nov 5, 2018

I'm experiencing the same issue.

Though, @fzarifian my test already had -p no:cacheprovider. By removing it, I was also able to remove the issue. I didn't need to add the -p no:stepwise part.

That being said, we ultimately left it in and opted to just set the pytest version like in your last comment.

@fzarifian

This comment has been minimized.

Contributor

fzarifian commented Nov 5, 2018

@amustafa : on my runner cacheprovider and stepwise was enabled (by default), and i have the issue.
It should be related to a python 2.7 bug, could you confirm you use python3 ?

@fzarifian

This comment has been minimized.

Contributor

fzarifian commented Nov 5, 2018

(set the version is easier as it should be defined in the test runner image and not in all repositories you have to test)

@amustafa

This comment has been minimized.

amustafa commented Nov 5, 2018

@fzarifian Yes, the test failed when I was testing against python3.

jsf9k added a commit to dhs-ncats/ansible-role-htop that referenced this issue Nov 5, 2018

Add pytest.ini file
This is a workaround for
pytest-dev/pytest#4304.
@jsf9k

This comment has been minimized.

jsf9k commented Nov 5, 2018

Thanks for your help @fzarifian and @RonnyPfannschmidt! I added the pytest.ini file and now molecule test completes successfully.

chapmanb added a commit to bcbio/bcbio-nextgen that referenced this issue Nov 6, 2018

chapmanb added a commit to bcbio/bcbio-nextgen that referenced this issue Nov 6, 2018

dorukozturk added a commit to girder/ansible-role-large-image that referenced this issue Nov 6, 2018

dorukozturk added a commit to girder/ansible-role-large-image that referenced this issue Nov 6, 2018

@blueyed blueyed referenced this issue Nov 7, 2018

Closed

pytest version 3.10 Fails on python2.7 #4333

4 of 4 tasks complete

klueska added a commit to klueska-mesosphere/dcos-core-cli that referenced this issue Nov 8, 2018

klueska added a commit to klueska-mesosphere/dcos-core-cli that referenced this issue Nov 8, 2018

klueska added a commit to klueska-mesosphere/dcos-core-cli that referenced this issue Nov 8, 2018

klueska added a commit to dcos/dcos-core-cli that referenced this issue Nov 8, 2018

klueska added a commit to dcos/dcos-core-cli that referenced this issue Nov 8, 2018

klueska added a commit to dcos/dcos-core-cli that referenced this issue Nov 8, 2018

@seandst seandst referenced this issue Nov 8, 2018

Open

Fixin stuff #4

nicoddemus added a commit that referenced this issue Nov 8, 2018

Merge pull request #4307 from fzarifian/fzarifian-pr4304
#4304 the stepwise plugin must be blocked on cacheprovider plugin block request

@nicoddemus nicoddemus referenced this issue Nov 8, 2018

Closed

Refactor class StepwisePlugin. #4335

3 of 6 tasks complete

TizianoPerrucci added a commit to StackVista/stackstate-agent that referenced this issue Nov 9, 2018

TizianoPerrucci added a commit to StackVista/stackstate-agent that referenced this issue Nov 9, 2018

Release procedure (#28)
* packaging routines

* release stage

* detecting runtime files

* improve(pipeline) gitignore, adjustable repo codename

* improve(pipeline) tags builds go to stable

* splitted into repo with preview builds and repo with production builds

* STAC-2599 Rearrange molecule tests

* STAC-2599 Correct setup for molecule on ec2. Update stackstate-agent installation.

* STAC-2599 Always pass bucket to publish_package script

* STAC-2599 Improving security port def

* STAC-2599 Downgrade pytest due to pytest-dev/pytest#4304

tompscanlan pushed a commit to vmware/ansible-role-govc that referenced this issue Nov 9, 2018

tompscanlan added a commit to vmware/ansible-role-govc that referenced this issue Nov 9, 2018

update to latest molecule framework
* fix bug in pytest: pytest-dev/pytest#4304
* fix linting problems
* add script to get testing in docker up locally
* add test for latest govc
* bump default version

Signed-off-by: Tom Scanlan <tscanlan@vmware.com>

tompscanlan added a commit to vmware/ansible-role-govc that referenced this issue Nov 9, 2018

update to latest molecule framework (#9)
* fix bug in pytest: pytest-dev/pytest#4304
* fix linting problems
* add script to get testing in docker up locally
* add test for latest govc
* bump default version

Signed-off-by: Tom Scanlan <tscanlan@vmware.com>

frestr added a commit to quodlibet/quodlibet that referenced this issue Nov 11, 2018

pdonorio added a commit to proof-media/rchain-grpc that referenced this issue Nov 11, 2018

Update pytest to 3.10.1 (#25)
This PR updates [pytest](https://pypi.org/project/pytest) from **3.10.0** to **3.10.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.10.1
   ```
   ==========================

Bug Fixes
---------

- `4287 &lt;https://github.com/pytest-dev/pytest/issues/4287&gt;`_: Fix nested usage of debugging plugin (pdb), e.g. with pytester&#39;s ``testdir.runpytest``.


- `4304 &lt;https://github.com/pytest-dev/pytest/issues/4304&gt;`_: Block the ``stepwise`` plugin if ``cacheprovider`` is also blocked, as one depends on the other.


- `4306 &lt;https://github.com/pytest-dev/pytest/issues/4306&gt;`_: Parse ``minversion`` as an actual version and not as dot-separated strings.


- `4310 &lt;https://github.com/pytest-dev/pytest/issues/4310&gt;`_: Fix duplicate collection due to multiple args matching the same packages.


- `4321 &lt;https://github.com/pytest-dev/pytest/issues/4321&gt;`_: Fix ``item.nodeid`` with resolved symlinks.


- `4325 &lt;https://github.com/pytest-dev/pytest/issues/4325&gt;`_: Fix collection of direct symlinked files, where the target does not match ``python_files``.


- `4329 &lt;https://github.com/pytest-dev/pytest/issues/4329&gt;`_: Fix TypeError in report_collect with _collect_report_last_write.



Trivial/Internal Changes
------------------------

- `4305 &lt;https://github.com/pytest-dev/pytest/issues/4305&gt;`_: Replace byte/unicode helpers in test_capture with python level syntax.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pytest
  - Changelog: https://pyup.io/changelogs/pytest/
  - Homepage: https://docs.pytest.org/en/latest/
</details>

peterbe added a commit to mozilla-services/tecken that referenced this issue Nov 12, 2018

Update pytest to 3.10.1 (#1318)
This PR updates [pytest](https://pypi.org/project/pytest) from **3.10.0** to **3.10.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.10.1
   ```
   ==========================

Bug Fixes
---------

- `4287 &lt;https://github.com/pytest-dev/pytest/issues/4287&gt;`_: Fix nested usage of debugging plugin (pdb), e.g. with pytester&#39;s ``testdir.runpytest``.


- `4304 &lt;https://github.com/pytest-dev/pytest/issues/4304&gt;`_: Block the ``stepwise`` plugin if ``cacheprovider`` is also blocked, as one depends on the other.


- `4306 &lt;https://github.com/pytest-dev/pytest/issues/4306&gt;`_: Parse ``minversion`` as an actual version and not as dot-separated strings.


- `4310 &lt;https://github.com/pytest-dev/pytest/issues/4310&gt;`_: Fix duplicate collection due to multiple args matching the same packages.


- `4321 &lt;https://github.com/pytest-dev/pytest/issues/4321&gt;`_: Fix ``item.nodeid`` with resolved symlinks.


- `4325 &lt;https://github.com/pytest-dev/pytest/issues/4325&gt;`_: Fix collection of direct symlinked files, where the target does not match ``python_files``.


- `4329 &lt;https://github.com/pytest-dev/pytest/issues/4329&gt;`_: Fix TypeError in report_collect with _collect_report_last_write.



Trivial/Internal Changes
------------------------

- `4305 &lt;https://github.com/pytest-dev/pytest/issues/4305&gt;`_: Replace byte/unicode helpers in test_capture with python level syntax.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pytest
  - Changelog: https://pyup.io/changelogs/pytest/
  - Homepage: https://docs.pytest.org/en/latest/
</details>

peterbe added a commit to peterbe/django-peterbecom that referenced this issue Nov 12, 2018

Update pytest to 3.10.1 (#425)
This PR updates [pytest](https://pypi.org/project/pytest) from **3.10.0** to **3.10.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.10.1
   ```
   ==========================

Bug Fixes
---------

- `4287 &lt;https://github.com/pytest-dev/pytest/issues/4287&gt;`_: Fix nested usage of debugging plugin (pdb), e.g. with pytester&#39;s ``testdir.runpytest``.


- `4304 &lt;https://github.com/pytest-dev/pytest/issues/4304&gt;`_: Block the ``stepwise`` plugin if ``cacheprovider`` is also blocked, as one depends on the other.


- `4306 &lt;https://github.com/pytest-dev/pytest/issues/4306&gt;`_: Parse ``minversion`` as an actual version and not as dot-separated strings.


- `4310 &lt;https://github.com/pytest-dev/pytest/issues/4310&gt;`_: Fix duplicate collection due to multiple args matching the same packages.


- `4321 &lt;https://github.com/pytest-dev/pytest/issues/4321&gt;`_: Fix ``item.nodeid`` with resolved symlinks.


- `4325 &lt;https://github.com/pytest-dev/pytest/issues/4325&gt;`_: Fix collection of direct symlinked files, where the target does not match ``python_files``.


- `4329 &lt;https://github.com/pytest-dev/pytest/issues/4329&gt;`_: Fix TypeError in report_collect with _collect_report_last_write.



Trivial/Internal Changes
------------------------

- `4305 &lt;https://github.com/pytest-dev/pytest/issues/4305&gt;`_: Replace byte/unicode helpers in test_capture with python level syntax.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pytest
  - Changelog: https://pyup.io/changelogs/pytest/
  - Homepage: https://docs.pytest.org/en/latest/
</details>

bors bot added a commit to mozilla/normandy that referenced this issue Nov 12, 2018

Merge #1617
1617: Scheduled weekly dependency update for week 45 r=peterbe a=pyup-bot






### Update [botocore](https://pypi.org/project/botocore) from **1.12.33** to **1.12.42**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.12.42
   ```
   =======

* api-change:``mediapackage``: Update mediapackage client to latest version
   ```
   
  
  
   ### 1.12.41
   ```
   =======

* api-change:``medialive``: Update medialive client to latest version
* api-change:``dlm``: Update dlm client to latest version
* api-change:``events``: Update events client to latest version
   ```
   
  
  
   ### 1.12.40
   ```
   =======

* api-change:``dms``: Update dms client to latest version
* api-change:``ce``: Update ce client to latest version
* api-change:``ec2``: Update ec2 client to latest version
   ```
   
  
  
   ### 1.12.39
   ```
   =======

* api-change:``codebuild``: Update codebuild client to latest version
* api-change:``pinpoint``: Update pinpoint client to latest version
* api-change:``ec2``: Update ec2 client to latest version
* api-change:``pinpoint-email``: Update pinpoint-email client to latest version
* api-change:``apigateway``: Update apigateway client to latest version
* api-change:``waf-regional``: Update waf-regional client to latest version
* bugfix:session config: Added the default session configuration tuples back to session.session_vars_map.
   ```
   
  
  
   ### 1.12.38
   ```
   =======

* api-change:``eks``: Update eks client to latest version
* enhancement:Configuration: Added new configuration provider methods allowing for more flexibility in how a botocore session loads a particular configuration value.
* api-change:``serverlessrepo``: Update serverlessrepo client to latest version
   ```
   
  
  
   ### 1.12.37
   ```
   =======

* api-change:``rekognition``: Update rekognition client to latest version
* api-change:``clouddirectory``: Update clouddirectory client to latest version
   ```
   
  
  
   ### 1.12.36
   ```
   =======

* api-change:``servicecatalog``: Update servicecatalog client to latest version
* enhancement:Exceptions: Add the ability to pickle botocore exceptions (`834 &lt;https://github.com/boto/botocore/issues/834&gt;`__)
   ```
   
  
  
   ### 1.12.35
   ```
   =======

* api-change:``mediastore-data``: Update mediastore-data client to latest version
* api-change:``secretsmanager``: Update secretsmanager client to latest version
* api-change:``greengrass``: Update greengrass client to latest version
* api-change:``config``: Update config client to latest version
   ```
   
  
  
   ### 1.12.34
   ```
   =======

* api-change:``chime``: Update chime client to latest version
* api-change:``rds``: Update rds client to latest version
* api-change:``dms``: Update dms client to latest version
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/botocore
  - Changelog: https://pyup.io/changelogs/botocore/
  - Repo: https://github.com/boto/botocore
</details>





### Update [future](https://pypi.org/project/future) from **0.17.0** to **0.17.1**.


*The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)*

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/future
  - Changelog: https://pyup.io/changelogs/future/
  - Homepage: https://python-future.org
  - Docs: https://pythonhosted.org/future/
</details>





### Update [MarkupSafe](https://pypi.org/project/MarkupSafe) from **1.0** to **1.1.0**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.1.0
   ```
   -------------

Released 2018-11-05

-   Drop support for Python 2.6 and 3.3.
-   Build wheels for Linux, Mac, and Windows, allowing systems without
    a compiler to take advantage of the C extension speedups. (`104`_)
-   Use newer CPython API on Python 3, resulting in a 1.5x speedup.
    (`64`_)
-   ``escape`` wraps ``__html__`` result in ``Markup``, consistent with
    documented behavior. (`69`_)

.. _64: pallets/markupsafe#64
.. _69: pallets/markupsafe#69
.. _104: pallets/markupsafe#104
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/markupsafe
  - Changelog: https://pyup.io/changelogs/markupsafe/
  - Homepage: https://www.palletsprojects.com/p/markupsafe/
</details>





### Update [urllib3](https://pypi.org/project/urllib3) from **1.24** to **1.24.1**.


*The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)*

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/urllib3
  - Changelog: https://pyup.io/changelogs/urllib3/
  - Docs: https://urllib3.readthedocs.io/
</details>





### Update [pyparsing](https://pypi.org/project/pyparsing) from **2.2.2** to **2.3.0**.


<details>
  <summary>Changelog</summary>
  
  
   ### 2.3.0
   ```
   -----------------------------
- NEW SUPPORT FOR UNICODE CHARACTER RANGES
  This release introduces the pyparsing_unicode namespace class, defining
  a series of language character sets to simplify the definition of alphas,
  nums, alphanums, and printables in the following language sets:
   . Arabic
   . Chinese
   . Cyrillic
   . Devanagari
   . Greek
   . Hebrew
   . Japanese (including Kanji, Katakana, and Hirigana subsets)
   . Korean
   . Latin1 (includes 7 and 8-bit Latin characters)
   . Thai
   . CJK (combination of Chinese, Japanese, and Korean sets)

  For example, your code can define words using:

    korean_word = Word(pyparsing_unicode.Korean.alphas)

  See their use in the updated examples greetingInGreek.py and
  greetingInKorean.py.

  This namespace class also offers access to these sets using their
  unicode identifiers.

- POSSIBLE API CHANGE: Fixed bug where a parse action that explicitly 
  returned the input ParseResults could add another nesting level in
  the results if the current expression had a results name.

        vals = pp.OneOrMore(pp.pyparsing_common.integer)(&quot;int_values&quot;)
        
        def add_total(tokens):
            tokens[&#39;total&#39;] = sum(tokens)
            return tokens   this line can be removed

        vals.addParseAction(add_total)
        print(vals.parseString(&quot;244 23 13 2343&quot;).dump())

  Before the fix, this code would print (note the extra nesting level):
  
    [244, 23, 13, 2343]
    - int_values: [244, 23, 13, 2343]
      - int_values: [244, 23, 13, 2343]
      - total: 2623
    - total: 2623

  With the fix, this code now prints:
  
    [244, 23, 13, 2343]
    - int_values: [244, 23, 13, 2343]
    - total: 2623

  This fix will change the structure of ParseResults returned if a 
  program defines a parse action that returns the tokens that were 
  sent in. This is not necessary, and statements like &quot;return tokens&quot; 
  in the example above can be safely deleted prior to upgrading to 
  this release, in order to avoid the bug and get the new behavior.

  Reported by seron in Issue 22, nice catch!

- POSSIBLE API CHANGE: Fixed a related bug where a results name 
  erroneously created a second level of hierarchy in the returned 
  ParseResults. The intent for accumulating results names into ParseResults
  is that, in the absence of Group&#39;ing, all names get merged into a
  common namespace. This allows us to write:
  
       key_value_expr = (Word(alphas)(&quot;key&quot;) + &#39;=&#39; + Word(nums)(&quot;value&quot;))
       result = key_value_expr.parseString(&quot;a = 100&quot;) 
    
  and have result structured as {&quot;key&quot;: &quot;a&quot;, &quot;value&quot;: &quot;100&quot;} 
  instead of [{&quot;key&quot;: &quot;a&quot;}, {&quot;value&quot;: &quot;100&quot;}].
  
  However, if a named expression is used in a higher-level non-Group 
  expression that *also* has a name, a false sub-level would be created 
  in the namespace:

        num = pp.Word(pp.nums)
        num_pair = (&quot;[&quot; + (num(&quot;A&quot;) + num(&quot;B&quot;))(&quot;values&quot;) + &quot;]&quot;)
        U = num_pair.parseString(&quot;[ 10 20 ]&quot;)
        print(U.dump())

  Since there is no grouping, &quot;A&quot;, &quot;B&quot;, and &quot;values&quot; should all appear
  at the same level in the results, as:
  
        [&#39;[&#39;, &#39;10&#39;, &#39;20&#39;, &#39;]&#39;]
        - A: &#39;10&#39;
        - B: &#39;20&#39;
        - values: [&#39;10&#39;, &#39;20&#39;]

  Instead, an extra level of &quot;A&quot; and &quot;B&quot; show up under &quot;values&quot;:
  
        [&#39;[&#39;, &#39;10&#39;, &#39;20&#39;, &#39;]&#39;]
        - A: &#39;10&#39;
        - B: &#39;20&#39;
        - values: [&#39;10&#39;, &#39;20&#39;]
          - A: &#39;10&#39;
          - B: &#39;20&#39;

  This bug has been fixed. Now, if this hierarchy is desired, then a
  Group should be added:
  
        num_pair = (&quot;[&quot; + pp.Group(num(&quot;A&quot;) + num(&quot;B&quot;))(&quot;values&quot;) + &quot;]&quot;)

  Giving:
  
        [&#39;[&#39;, [&#39;10&#39;, &#39;20&#39;], &#39;]&#39;]
        - values: [&#39;10&#39;, &#39;20&#39;]
          - A: &#39;10&#39;
          - B: &#39;20&#39;

  But in no case should &quot;A&quot; and &quot;B&quot; appear in multiple levels. This bug-fix
  fixes that.
  
  If you have current code which relies on this behavior, then add or remove
  Groups as necessary to get your intended results structure.
  
  Reported by Athanasios Anastasiou.

- IndexError&#39;s raised in parse actions will get explicitly reraised 
  as ParseExceptions that wrap the original IndexError. Since 
  IndexError sometimes occurs as part of pyparsing&#39;s normal parsing 
  logic, IndexErrors that are raised during a parse action may have
  gotten silently reinterpreted as parsing errors. To retain the 
  information from the IndexError, these exceptions will now be 
  raised as ParseExceptions that reference the original IndexError. 
  This wrapping will only be visible when run under Python3, since it
  emulates &quot;raise ... from ...&quot; syntax. 
  
  Addresses Issue 4, reported by guswns0528.

- Added Char class to simplify defining expressions of a single
  character. (Char(&quot;abc&quot;) is equivalent to Word(&quot;abc&quot;, exact=1))

- Added class PrecededBy to perform lookbehind tests. PrecededBy is 
  used in the same way as FollowedBy, passing in an expression that
  must occur just prior to the current parse location.
  
  For fixed-length expressions like a Literal, Keyword, Char, or a 
  Word with an `exact` or `maxLen` length given, `PrecededBy(expr)` 
  is sufficient. For varying length expressions like a Word with no 
  given maximum length, `PrecededBy` must be constructed with an 
  integer `retreat` argument, as in 
  `PrecededBy(Word(alphas, nums), retreat=10)`, to specify the maximum 
  number of characters pyparsing must look backward to make a match. 
  pyparsing will check all the values from 1 up to retreat characters 
  back from the current parse location.

  When stepping backwards through the input string, PrecededBy does 
  *not* skip over whitespace.
  
  PrecededBy can be created with a results name so that, even though
  it always returns an empty parse result, the result *can* include
  named results.
  
  Idea first suggested in Issue 30 by Freakwill.

- Updated FollowedBy to accept expressions that contain named results,
  so that results names defined in the lookahead expression will be 
  returned, even though FollowedBy always returns an empty list.
  Inspired by the same feature implemented in PrecededBy.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pyparsing
  - Changelog: https://pyup.io/changelogs/pyparsing/
  - Repo: https://github.com/pyparsing/pyparsing/
  - Docs: https://pythonhosted.org/pyparsing/
</details>





### Update [google-api-core](https://pypi.org/project/google-api-core) from **1.5.0** to **1.5.2**.


*The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)*

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/google-api-core
  - Repo: https://github.com/GoogleCloudPlatform/google-cloud-python
</details>





### Update [google-auth](https://pypi.org/project/google-auth) from **1.5.1** to **1.6.0**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.6.0
   ```
   ------

11-09-2018 11:07 PST

New Features
++++++++++++

- Add google.auth.impersonated_credentials ([299](googleapis/google-auth-library-python#299))

Documentation
+++++++++++++

- Update link to documentation for default credentials ([296](googleapis/google-auth-library-python#296))
- Update github issue templates ([300](googleapis/google-auth-library-python#300))
- Remove punctuation which becomes part of the url ([284](googleapis/google-auth-library-python#284))

Internal / Testing Changes
++++++++++++++++++++++++++

- Update trampoline.sh ([302](googleapis/google-auth-library-python#302))
- Enable static type checking with pytype ([298](googleapis/google-auth-library-python#298))
- Make classifiers in setup.py an array. ([280](googleapis/google-auth-library-python#280))
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/google-auth
  - Changelog: https://pyup.io/changelogs/google-auth/
  - Repo: https://github.com/GoogleCloudPlatform/google-auth-library-python
</details>





### Update [googleapis-common-protos](https://pypi.org/project/googleapis-common-protos) from **1.5.3** to **1.5.5**.


*The bot wasn't able to find a changelog for this release. [Got an idea?](https://github.com/pyupio/changelogs/issues/new)*

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/googleapis-common-protos
  - Repo: https://github.com/googleapis/googleapis
</details>





### Update [cachetools](https://pypi.org/project/cachetools) from **2.1.0** to **3.0.0**.


<details>
  <summary>Changelog</summary>
  
  
   ### 3.0.0
   ```
   -------------------

- Officially support Python 3.7.

- Drop Python 3.3 support (breaking change).

- Remove ``missing`` cache constructor parameter (breaking change).

- Remove ``self`` from ``cachedmethod`` key arguments (breaking
  change).

- Add support for ``maxsize=None`` in ``cachetools.func`` decorators.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/cachetools
  - Changelog: https://pyup.io/changelogs/cachetools/
  - Repo: https://github.com/tkem/cachetools
</details>





### Update [boto3](https://pypi.org/project/boto3) from **1.9.33** to **1.9.42**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.9.42
   ```
   ======

* api-change:``mediapackage``: [``botocore``] Update mediapackage client to latest version
   ```
   
  
  
   ### 1.9.41
   ```
   ======

* api-change:``medialive``: [``botocore``] Update medialive client to latest version
* api-change:``dlm``: [``botocore``] Update dlm client to latest version
* api-change:``events``: [``botocore``] Update events client to latest version
   ```
   
  
  
   ### 1.9.40
   ```
   ======

* api-change:``dms``: [``botocore``] Update dms client to latest version
* api-change:``ce``: [``botocore``] Update ce client to latest version
* api-change:``ec2``: [``botocore``] Update ec2 client to latest version
   ```
   
  
  
   ### 1.9.39
   ```
   ======

* api-change:``codebuild``: [``botocore``] Update codebuild client to latest version
* api-change:``pinpoint``: [``botocore``] Update pinpoint client to latest version
* api-change:``ec2``: [``botocore``] Update ec2 client to latest version
* api-change:``pinpoint-email``: [``botocore``] Update pinpoint-email client to latest version
* api-change:``apigateway``: [``botocore``] Update apigateway client to latest version
* api-change:``waf-regional``: [``botocore``] Update waf-regional client to latest version
* bugfix:session config: [``botocore``] Added the default session configuration tuples back to session.session_vars_map.
   ```
   
  
  
   ### 1.9.38
   ```
   ======

* api-change:``eks``: [``botocore``] Update eks client to latest version
* enhancement:Configuration: [``botocore``] Added new configuration provider methods allowing for more flexibility in how a botocore session loads a particular configuration value.
* api-change:``serverlessrepo``: [``botocore``] Update serverlessrepo client to latest version
   ```
   
  
  
   ### 1.9.37
   ```
   ======

* api-change:``rekognition``: [``botocore``] Update rekognition client to latest version
* api-change:``clouddirectory``: [``botocore``] Update clouddirectory client to latest version
   ```
   
  
  
   ### 1.9.36
   ```
   ======

* api-change:``servicecatalog``: [``botocore``] Update servicecatalog client to latest version
* enhancement:Exceptions: [``botocore``] Add the ability to pickle botocore exceptions (`834 &lt;https://github.com/boto/botocore/issues/834&gt;`__)
   ```
   
  
  
   ### 1.9.35
   ```
   ======

* api-change:``mediastore-data``: [``botocore``] Update mediastore-data client to latest version
* api-change:``secretsmanager``: [``botocore``] Update secretsmanager client to latest version
* api-change:``greengrass``: [``botocore``] Update greengrass client to latest version
* api-change:``config``: [``botocore``] Update config client to latest version
   ```
   
  
  
   ### 1.9.34
   ```
   ======

* api-change:``chime``: [``botocore``] Update chime client to latest version
* api-change:``rds``: [``botocore``] Update rds client to latest version
* api-change:``dms``: [``botocore``] Update dms client to latest version
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/boto3
  - Changelog: https://pyup.io/changelogs/boto3/
  - Repo: https://github.com/boto/boto3
</details>





### Update [psycopg2](https://pypi.org/project/psycopg2) from **2.7.5** to **2.7.6.1**.


<details>
  <summary>Changelog</summary>
  
  
   ### 2.7.6
   ```
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^

- Close named cursors if exist, even if `~cursor.execute()` wasn&#39;t called
  (🎫`746`).
- Fixed building on modern FreeBSD versions with Python 3.7 (🎫`755`).
- Fixed hang trying to :sql:`COPY` via `~cursor.execute()` in asynchronous
  connections (🎫`781`).
- Fixed adaptation of arrays of empty arrays (🎫`788`).
- Fixed segfault accessing the connection&#39;s `~connection.readonly` and
  `~connection.deferrable` attributes repeatedly (🎫`790`).
- `~psycopg2.extras.execute_values()` accepts `~psycopg2.sql.Composable`
  objects (🎫`794`).
- `~psycopg2.errorcodes` map updated to PostgreSQL 11.
- Wheel package compiled against PostgreSQL 10.5 libpq and OpenSSL 1.0.2p.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/psycopg2
  - Changelog: https://pyup.io/changelogs/psycopg2/
  - Homepage: http://initd.org/psycopg/
</details>





### Update [pytest](https://pypi.org/project/pytest) from **3.9.3** to **3.10.1**.


<details>
  <summary>Changelog</summary>
  
  
   ### 3.10.1
   ```
   ==========================

Bug Fixes
---------

- `4287 &lt;https://github.com/pytest-dev/pytest/issues/4287&gt;`_: Fix nested usage of debugging plugin (pdb), e.g. with pytester&#39;s ``testdir.runpytest``.


- `4304 &lt;https://github.com/pytest-dev/pytest/issues/4304&gt;`_: Block the ``stepwise`` plugin if ``cacheprovider`` is also blocked, as one depends on the other.


- `4306 &lt;https://github.com/pytest-dev/pytest/issues/4306&gt;`_: Parse ``minversion`` as an actual version and not as dot-separated strings.


- `4310 &lt;https://github.com/pytest-dev/pytest/issues/4310&gt;`_: Fix duplicate collection due to multiple args matching the same packages.


- `4321 &lt;https://github.com/pytest-dev/pytest/issues/4321&gt;`_: Fix ``item.nodeid`` with resolved symlinks.


- `4325 &lt;https://github.com/pytest-dev/pytest/issues/4325&gt;`_: Fix collection of direct symlinked files, where the target does not match ``python_files``.


- `4329 &lt;https://github.com/pytest-dev/pytest/issues/4329&gt;`_: Fix TypeError in report_collect with _collect_report_last_write.



Trivial/Internal Changes
------------------------

- `4305 &lt;https://github.com/pytest-dev/pytest/issues/4305&gt;`_: Replace byte/unicode helpers in test_capture with python level syntax.
   ```
   
  
  
   ### 3.10.0
   ```
   ==========================

Features
--------

- `2619 &lt;https://github.com/pytest-dev/pytest/issues/2619&gt;`_: Resume capturing output after ``continue`` with ``__import__(&quot;pdb&quot;).set_trace()``.

  This also adds a new ``pytest_leave_pdb`` hook, and passes in ``pdb`` to the
  existing ``pytest_enter_pdb`` hook.


- `4147 &lt;https://github.com/pytest-dev/pytest/issues/4147&gt;`_: Add ``--sw``, ``--stepwise`` as an alternative to ``--lf -x`` for stopping at the first failure, but starting the next test invocation from that test.  See `the documentation &lt;https://docs.pytest.org/en/latest/cache.htmlstepwise&gt;`__ for more info.


- `4188 &lt;https://github.com/pytest-dev/pytest/issues/4188&gt;`_: Make ``--color`` emit colorful dots when not running in verbose mode. Earlier, it would only colorize the test-by-test output if ``--verbose`` was also passed.


- `4225 &lt;https://github.com/pytest-dev/pytest/issues/4225&gt;`_: Improve performance with collection reporting in non-quiet mode with terminals.

  The &quot;collecting …&quot; message is only printed/updated every 0.5s.



Bug Fixes
---------

- `2701 &lt;https://github.com/pytest-dev/pytest/issues/2701&gt;`_: Fix false ``RemovedInPytest4Warning: usage of Session... is deprecated, please use pytest`` warnings.


- `4046 &lt;https://github.com/pytest-dev/pytest/issues/4046&gt;`_: Fix problems with running tests in package ``__init__.py`` files.


- `4260 &lt;https://github.com/pytest-dev/pytest/issues/4260&gt;`_: Swallow warnings during anonymous compilation of source.


- `4262 &lt;https://github.com/pytest-dev/pytest/issues/4262&gt;`_: Fix access denied error when deleting stale directories created by ``tmpdir`` / ``tmp_path``.


- `611 &lt;https://github.com/pytest-dev/pytest/issues/611&gt;`_: Naming a fixture ``request`` will now raise a warning: the ``request`` fixture is internal and
  should not be overwritten as it will lead to internal errors.

- `4266 &lt;https://github.com/pytest-dev/pytest/issues/4266&gt;`_: Handle (ignore) exceptions raised during collection, e.g. with Django&#39;s LazySettings proxy class.



Improved Documentation
----------------------

- `4255 &lt;https://github.com/pytest-dev/pytest/issues/4255&gt;`_: Added missing documentation about the fact that module names passed to filter warnings are not regex-escaped.



Trivial/Internal Changes
------------------------

- `4272 &lt;https://github.com/pytest-dev/pytest/issues/4272&gt;`_: Display cachedir also in non-verbose mode if non-default.


- `4277 &lt;https://github.com/pytest-dev/pytest/issues/4277&gt;`_: pdb: improve message about output capturing with ``set_trace``.

  Do not display &quot;IO-capturing turned off/on&quot; when ``-s`` is used to avoid
  confusion.


- `4279 &lt;https://github.com/pytest-dev/pytest/issues/4279&gt;`_: Improve message and stack level of warnings issued by ``monkeypatch.setenv`` when the value of the environment variable is not a ``str``.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pytest
  - Changelog: https://pyup.io/changelogs/pytest/
  - Homepage: https://docs.pytest.org/en/latest/
</details>





### Update [pytest-testrail](https://pypi.org/project/pytest-testrail) from **2.3.0** to **2.3.1**.


<details>
  <summary>Changelog</summary>
  
  
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pytest-testrail
  - Changelog: https://pyup.io/changelogs/pytest-testrail/
  - Repo: http://github.com/allankp/pytest-testrail/
</details>





### Update [requests](https://pypi.org/project/requests) from **2.20.0** to **2.20.1**.


<details>
  <summary>Changelog</summary>
  
  
   ### 2.20.1
   ```
   -------------------

**Bugfixes**

- Fixed bug with unintended Authorization header stripping for
  redirects using default ports (http/80, https/443).
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/requests
  - Changelog: https://pyup.io/changelogs/requests/
  - Homepage: http://python-requests.org
</details>





### Update [Sphinx](https://pypi.org/project/Sphinx) from **1.8.1** to **1.8.2**.


<details>
  <summary>Changelog</summary>
  
  
   ### 1.8.2
   ```
   =====================================

Incompatible changes
--------------------

* 5497: Do not include MathJax.js and jsmath.js unless it is really needed

Features added
--------------

* 5471: Show appropriate deprecation warnings

Bugs fixed
----------

* 5490: latex: enumerated list causes a crash with recommonmark
* 5492: sphinx-build fails to build docs w/ Python &lt; 3.5.2
* 3704: latex: wrong ``\label`` positioning for figures with a legend
* 5496: C++, fix assertion when a symbol is declared more than twice.
* 5493: gettext: crashed with broken template
* 5495: csv-table directive with file option in included file is broken (refs:
  4821)
* 5498: autodoc: unable to find type hints for a ``functools.partial``
* 5480: autodoc: unable to find type hints for unresolvable Forward references
* 5419: incompatible math_block node has been generated
* 5548: Fix ensuredir() in case of pre-existing file
* 5549: graphviz Correctly deal with non-existing static dir
* 3002: i18n: multiple footnote_references referring same footnote causes
  duplicated node_ids
* 5563: latex: footnote_references generated by extension causes LaTeX builder
  crashed
* 5561: make all-pdf fails with old xindy version
* 5557: quickstart: --no-batchfile isn&#39;t honored
* 3080: texinfo: multiline rubrics are broken
* 3080: texinfo: multiline citations are broken
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/sphinx
  - Changelog: https://pyup.io/changelogs/sphinx/
  - Homepage: http://sphinx-doc.org/
</details>







Co-authored-by: pyup-bot <github-bot@pyup.io>
@jsf9k

This comment has been minimized.

jsf9k commented Nov 13, 2018

I confirmed that with version 3.10.1 I no longer have the issue.

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Nov 13, 2018

Thanks @jsf9k for the follow up.

bors bot added a commit to rehandalal/therapist that referenced this issue Nov 14, 2018

Merge #45
45: Update pytest to 3.10.1 r=rehandalal a=pyup-bot


This PR updates [pytest](https://pypi.org/project/pytest) from **3.10.0** to **3.10.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.10.1
   ```
   ==========================

Bug Fixes
---------

- `4287 &lt;https://github.com/pytest-dev/pytest/issues/4287&gt;`_: Fix nested usage of debugging plugin (pdb), e.g. with pytester&#39;s ``testdir.runpytest``.


- `4304 &lt;https://github.com/pytest-dev/pytest/issues/4304&gt;`_: Block the ``stepwise`` plugin if ``cacheprovider`` is also blocked, as one depends on the other.


- `4306 &lt;https://github.com/pytest-dev/pytest/issues/4306&gt;`_: Parse ``minversion`` as an actual version and not as dot-separated strings.


- `4310 &lt;https://github.com/pytest-dev/pytest/issues/4310&gt;`_: Fix duplicate collection due to multiple args matching the same packages.


- `4321 &lt;https://github.com/pytest-dev/pytest/issues/4321&gt;`_: Fix ``item.nodeid`` with resolved symlinks.


- `4325 &lt;https://github.com/pytest-dev/pytest/issues/4325&gt;`_: Fix collection of direct symlinked files, where the target does not match ``python_files``.


- `4329 &lt;https://github.com/pytest-dev/pytest/issues/4329&gt;`_: Fix TypeError in report_collect with _collect_report_last_write.



Trivial/Internal Changes
------------------------

- `4305 &lt;https://github.com/pytest-dev/pytest/issues/4305&gt;`_: Replace byte/unicode helpers in test_capture with python level syntax.
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pytest
  - Changelog: https://pyup.io/changelogs/pytest/
  - Homepage: https://docs.pytest.org/en/latest/
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>

lazka added a commit to quodlibet/quodlibet that referenced this issue Nov 18, 2018

bersace added a commit to bersace/temboard-agent that referenced this issue Nov 22, 2018

bersace added a commit to bersace/temboard-agent that referenced this issue Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment