Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest's own tests fail with pytest-randomly #4351

Closed
blueyed opened this issue Nov 8, 2018 · 2 comments · Fixed by blueyed/pytest#186
Closed

Pytest's own tests fail with pytest-randomly #4351

blueyed opened this issue Nov 8, 2018 · 2 comments · Fixed by blueyed/pytest#186
Labels
type: enhancement new feature or API change, should be merged into features branch type: infrastructure improvement to development/releases/CI structure

Comments

@blueyed
Copy link
Contributor

blueyed commented Nov 8, 2018

Some tests are failing when installing pytest-randomly.

I've tried using -p no:randomly with the inner runpytest, but it appears that it has no (or not enough) effect - IIRC plugins can only be added there, but not removed.

Also this would not really be a general solution (i.e. when using another similar plugin with another name), so maybe a whitelist should be used always?!
@blueyed blueyed added type: enhancement new feature or API change, should be merged into features branch type: infrastructure improvement to development/releases/CI structure labels Nov 8, 2018
blueyed added a commit to blueyed/pytest that referenced this issue Dec 9, 2018
@blueyed
pytester: do not use outer plugins
213e1d9 
Sets PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 by default.

Fixes pytest-dev#4351.
@blueyed blueyed mentioned this issue Dec 9, 2018
Closed
@blueyed
Copy link
Contributor Author

blueyed commented Dec 9, 2018

Also installing/using pytest-pdb is problematic, because its pytest_configure raises ValueError the second time it gets called to configure/extend pdb.Pdb.

The general problem here appears to be that pytester uses any outer plugins also for internal runs.

#4518 should fix this.

@RonnyPfannschmidt
Copy link
Member

@blueyed it should be noted that this fix breaks testing for plugins using pytester

@blueyed blueyed mentioned this issue Apr 4, 2019
Closed
@blueyed blueyed mentioned this issue Jun 24, 2019
Closed
@blueyed blueyed closed this as completed Nov 27, 2019
blueyed added a commit to blueyed/pytest that referenced this issue Feb 1, 2020
@blueyed
testing/conftest.py: only use pytester and xdist
b9889d0 
I.e. not e.g. pytest-randomly.

Fixes pytest-dev#4351.
This was referenced Feb 1, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement new feature or API change, should be merged into features branch type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing/conftest.py: testdir: set PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 blueyed/pytest
2 participants
@blueyed @RonnyPfannschmidt