Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use randomly for two tests which assert ordering #5472

Closed
wants to merge 1 commit into from
Closed

don't use randomly for two tests which assert ordering #5472

wants to merge 1 commit into from

Conversation

asottile
Copy link
Member

makes it easier to debug #5468

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #5472 into master will decrease coverage by 0.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5472      +/-   ##
==========================================
- Coverage   96.03%   95.28%   -0.76%     
==========================================
  Files         115      115              
  Lines       25512    25512              
  Branches     2480     2480              
==========================================
- Hits        24501    24309     -192     
- Misses        706      888     +182     
- Partials      305      315      +10
Impacted Files Coverage Δ
testing/python/integration.py 93.57% <100%> (ø) ⬆️
testing/python/approx.py 80.37% <0%> (-19.25%) ⬇️
testing/test_unittest.py 86.3% <0%> (-12.79%) ⬇️
src/_pytest/unittest.py 83.24% <0%> (-11.74%) ⬇️
src/_pytest/python_api.py 86.66% <0%> (-10.67%) ⬇️
src/_pytest/pytester.py 85.12% <0%> (-5.9%) ⬇️
src/_pytest/doctest.py 93.68% <0%> (-2.24%) ⬇️
src/_pytest/skipping.py 93.75% <0%> (-2.09%) ⬇️
testing/test_assertrewrite.py 82.26% <0%> (-1.53%) ⬇️
src/_pytest/capture.py 93.42% <0%> (-1.32%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d01dd3...fea77e6. Read the comment docs.

@asottile
Copy link
Member Author

actually a good percentage of the testsuite isn't compatible, abandoning this

@asottile asottile closed this Jun 23, 2019
@asottile asottile deleted the no_randomly branch June 23, 2019 18:33
@blueyed
Copy link
Contributor

blueyed commented Jun 24, 2019

actually a good percentage of the testsuite isn't compatible, abandoning this

Still better than nothing maybe? (ref: #4351)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants