-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing for FixtureRequest.param #10133
Conversation
259ebc8
to
ed12c9a
Compare
For now, mark it as Any until pytest-dev#8073 is solved Fixes pytest-dev#9514
ed12c9a
to
895164c
Compare
Failures in 3.11 can be ignored as they have been fixed by #10132. |
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I will leave to @bluetech to given the final approve/merge. 😁
I wonder how tricky it would actually be to have the requests class getattr return a bound generic of the subrequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me as a stop gap.
I added a suggestion for a comment that makes the situation clear, for when we properly tackle this in the future.
Co-authored-by: Ran Benita <ran@unusedvar.com>
Thanks @nipunn1313! |
For now, mark it as Any until #8073 is solved
Closes #9514
(added a type annotation in the file to prove it works)
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.AUTHORS
in alphabetical order.