vendor py.path and py.error #10396

asottile · 2022-10-19T14:18:15Z

there is one tiny behavioural change -- that is sysexec now raises RuntimeError instead of a sepcialized py.process.cmdexec error -- I think this is probably fine, I doubt anyone is actually using py.path.local.sysexec 🤷

otherwise we could vendor that module too -- but seems not worth

RonnyPfannschmidt

That particular hack hurts in a special way

RonnyPfannschmidt · 2022-10-19T16:25:57Z

src/py.py

+import _pytest._py.error as error
+import _pytest._py.path as path
+
+sys.modules["py.error"] = error


Thanks i hate it, but it's a fun hack

heh -- it's basically what apipkg does iirc

It is, but the overreaching hack into the python import system to be backward compatible in this "yikes this works" way is quite something

asottile · 2022-10-19T17:34:00Z

I guess I should finish the linting and typing for _pytest._py.path then huh

for more information, see https://pre-commit.ci

nicoddemus · 2022-10-20T00:31:00Z

@RonnyPfannschmidt so you are OK with vendoring py.path? @The-Compiler any opinions?

I personally like vendoring it, as we can drop py immediately. 👍

In addition, we should also port the tests for py.path.local in this vendoring process (or perhaps you plan to do it later, that's why this is a draft).

francesco-ballarin · 2022-10-26T05:30:19Z

Hi,
I want to report a side effect of this change when using mypy. py used to be typed, while apparently the vendored library is not. Downstream developers that define pytest hooks may now see mypy errors like:

nbvalx/pytest_hooks_notebooks.py:32: error: Skipping analyzing "py": module is
installed, but missing library stubs or py.typed marker  [import]
    import py
    ^
nbvalx/pytest_hooks_notebooks.py:32: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
nbvalx/pytest_hooks_notebooks.py:412: error: Argument 2 to "collect_file"
becomes "Any" due to an unfollowed import  [no-any-unimported]
    def collect_file(file_path: pathlib.Path, path: py.path.local, parent:...
    ^

I'll leave it to you to decide if it is worth it to add back that support (downstream developers can easily add a couple of ignores, especially knowing that py.path is being deprecated anyway), but I want to report this here for future reference because at the beginning I couldn't wrap my head around what had happened (latest py release was one year ago, and surely I had ran my CI last week without errors) and it took me a while to figure out what was going on.

Cheers,
Francesco

The-Compiler · 2022-10-26T06:58:22Z

@francesco-ballarin I opened #10435 for this. Maybe there's an easy way we can fix this, but in here, this is likely to get lost.

With pytest 7.2, the remaining parts of the "py.path" library got vendored, to get rid of the dependency: pytest-dev/pytest#10396 However, this breaks due to pytest_mypy_plugins importing private API: File ".../pytest_mypy_plugins/collect.py", line 13, in <module> from py._path.local import LocalPath ModuleNotFoundError: No module named 'py._path'; 'py' is not a package Use py.path.local instead (the public name of the same type), which is part of the shim included in pytest.

The py dependency has been removed in pytest: pytest-dev/pytest#10396

Since pytest-dev/pytest#10396 the py library is no longer installed, but dumb-init needs 'py._path'. Fixes: ImportError while importing test module '/tmp/tmp.k8zSDBKT6S/dumb-init-1.2.5/tests/child_processes_test.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/lib/python3.8/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/child_processes_test.py:10: in <module> from testing import is_alive testing/__init__.py:11: in <module> from py._path.local import LocalPath E ModuleNotFoundError: No module named 'py._path'; 'py' is not a package Issue filed upstream: Yelp/dumb-init#286 Signed-off-by: Tim Orling <tim.orling@konsulko.com>

Append 'py' to dumb-init*/requirements-dev.txt Since pytest-dev/pytest#10396 the py library is no longer installed, but dumb-init needs 'py._path'. Fixes: ImportError while importing test module '/tmp/tmp.k8zSDBKT6S/dumb-init-1.2.5/tests/child_processes_test.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/lib/python3.8/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/child_processes_test.py:10: in <module> from testing import is_alive testing/__init__.py:11: in <module> from py._path.local import LocalPath E ModuleNotFoundError: No module named 'py._path'; 'py' is not a package Issue filed upstream: Yelp/dumb-init#286 Signed-off-by: Tim Orling <tim.orling@konsulko.com>

The py dependency has been removed in pytest: pytest-dev/pytest#10396

pytest-dev/pytest#10396 git-svn-id: file:///srv/repos/svn-community/svn@1340954 9fca08f4-af9d-4005-b8df-a31f2cc04f65

python-py was brought in by older pytest [1][2] [1] 6687aae [2] pytest-dev/pytest#10396 git-svn-id: file:///srv/repos/svn-community/svn@1342284 9fca08f4-af9d-4005-b8df-a31f2cc04f65

asottile force-pushed the pylib-hax branch 3 times, most recently from 4e2ccb9 to 05b6c96 Compare October 19, 2022 14:34

asottile mentioned this pull request Oct 19, 2022

Plan for dropping/deprecating submodules of py and releasing v2.0 pytest-dev/py#288

Open

asottile force-pushed the pylib-hax branch from fb6a4b1 to 1d5f957 Compare October 19, 2022 16:05

RonnyPfannschmidt approved these changes Oct 19, 2022

View changes

asottile force-pushed the pylib-hax branch from a4b77bf to 158bde7 Compare October 19, 2022 17:24

asottile and others added 8 commits October 19, 2022 16:52

vendor py.path and py.error

19dda7c

[pre-commit.ci] auto fixes from pre-commit.com hooks

49abbf2

for more information, see https://pre-commit.ci

use module __getattr__ for py.error to fix doctesting

349f4bf

use getrawcode from _pytest._code

965e942

remove other py.* accesses in _pytest._py.path

a7c1fc2

_pytest._py.path: remove fspath compat

8a15177

_pytest._py.path: remove _cmp compat

00e2f1c

_pytest._py.path: remove decorator compat

382209d

asottile force-pushed the pylib-hax branch from 158bde7 to 0bfe50d Compare October 19, 2022 22:01

asottile added 8 commits October 19, 2022 21:42

_pytest._py.error: mypy typing

eebbfc6

_pytest._py.path: importlib mode always available

63c4d45

_pytest._py.path: flake8 fixes

73349ef

_pytest._py.path: combine Checkers classes

af078f3

_pytest._py.path: combine PosixPath into LocalPath

6660d45

_pytest._py.path: combine PathBase and LocalPath

ed4c18f

_pytest._py.path: get mypy passing

59d8f8a

add py.path.local tests

82344ba

asottile force-pushed the pylib-hax branch 2 times, most recently from 5d9f74b to dc0cb0d Compare October 20, 2022 02:18

asottile added 2 commits October 19, 2022 22:18

fix test pollution of sys.modules

dc0cb0d

adjust tests if py library is installed

02a9371

The-Compiler mentioned this pull request Oct 26, 2022

Missing type exports for vendored py #10435

Open

The-Compiler mentioned this pull request Oct 26, 2022

Fix compatibility with pytest 7.2 typeddjango/pytest-mypy-plugins#106

Merged

guewen added a commit to guewen/pytest-odoo that referenced this pull request Oct 26, 2022

Remove dependency on py lib

8276861

The py dependency has been removed in pytest: pytest-dev/pytest#10396

guewen mentioned this pull request Oct 26, 2022

Remove dependency on py lib camptocamp/pytest-odoo#53

Merged

FriedrichFroebel mentioned this pull request Oct 26, 2022

Tests break with pytest 7.2.0 hsnr-gamera/gamera-4#59

Closed

ns-rse mentioned this pull request Oct 27, 2022

Add py as requirement for test claritychallenge/clarity#95

Closed

moto-timo mentioned this pull request Oct 29, 2022

pytest 7.2.0 no longer installs py Yelp/dumb-init#286

Closed

simahawk pushed a commit to guewen/pytest-odoo that referenced this pull request Oct 31, 2022

Remove dependency on py lib

894e300

The py dependency has been removed in pytest: pytest-dev/pytest#10396

juanitosvq mentioned this pull request Nov 1, 2022

Dependency with "vulnerable" version of py tox-dev/tox#2524

Closed

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Nov 2, 2022

upgpkg: python-pytest 7.2.0-2: Remove python-py dep

6687aae

pytest-dev/pytest#10396 git-svn-id: file:///srv/repos/svn-community/svn@1340954 9fca08f4-af9d-4005-b8df-a31f2cc04f65

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Nov 2, 2022

upgpkg: python-pytest 7.2.0-2: Remove python-py dep

faa0702

pytest-dev/pytest#10396 git-svn-id: file:///srv/repos/svn-community/svn@1340954 9fca08f4-af9d-4005-b8df-a31f2cc04f65

ahebrank mentioned this pull request Nov 2, 2022

Add py as dependency to remeditate AttributeError: module 'py' has no attribute 'io' taverntesting/tavern#818

Merged

d-chambers mentioned this pull request Nov 2, 2022

CI broken obspy/obspy#3198

Closed

1 task

This was referenced Nov 3, 2022

Drop dependency on glob2 pytest-dev/pytest-bdd#570

Merged

New release for pytest 7.2 compatibility? pytest-dev/pytest-bdd#568

Closed

eaidova mentioned this pull request Nov 6, 2022

[PyOV] Enable Python 3.10 on Azure CI openvinotoolkit/openvino#12578

Merged

IlyaMuravjov mentioned this pull request Nov 10, 2022

Замена py.test на pytest в run_tests, так как pytest 7.2.0 больше не зависит от py FormalLanguageConstrainedPathQuerying/formal-lang-course#51

Merged

stanislavlevin mentioned this pull request Nov 14, 2022

pytest no longer bundles py cloudpipe/cloudpickle#487

Closed

rsebille mentioned this pull request Nov 14, 2022

Relâchement des dépendances de dev betagouv/itou#1699

Merged

vendor py.path and py.error #10396

vendor py.path and py.error #10396

asottile commented Oct 19, 2022 •

edited

RonnyPfannschmidt left a comment

RonnyPfannschmidt Oct 19, 2022

asottile Oct 19, 2022

RonnyPfannschmidt Oct 19, 2022

asottile commented Oct 19, 2022

nicoddemus commented Oct 20, 2022 •

edited

francesco-ballarin commented Oct 26, 2022

The-Compiler commented Oct 26, 2022

vendor py.path and py.error #10396

vendor py.path and py.error #10396

Conversation

asottile commented Oct 19, 2022 • edited

RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

RonnyPfannschmidt Oct 19, 2022

Choose a reason for hiding this comment

asottile Oct 19, 2022

Choose a reason for hiding this comment

RonnyPfannschmidt Oct 19, 2022

Choose a reason for hiding this comment

asottile commented Oct 19, 2022

nicoddemus commented Oct 20, 2022 • edited

francesco-ballarin commented Oct 26, 2022

The-Compiler commented Oct 26, 2022

asottile commented Oct 19, 2022 •

edited

nicoddemus commented Oct 20, 2022 •

edited