-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OSError in tmpdir on emscripten due to missing getuid() #10766
Conversation
Thanks @rdb! FYI decided to move the uid-handling logic to a separate function in Would appreciate a second set of eyes reviewing the change. 👍 |
@@ -46,7 +45,7 @@ | |||
# fmt: on | |||
|
|||
|
|||
def legacy_path(path: Union[str, "os.PathLike[str]"]) -> LEGACY_PATH: | |||
def legacy_path(path: str | os.PathLike[str]) -> LEGACY_PATH: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: type annotation changes were introduced by pyupgrade
because I added the from __future__ import annotations
import.
9cf64d7
to
cb9e8be
Compare
Thanks. Seems fine, I built with your changes and our test suite is still passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's merge 👍
Emscripten defines
getuid()
as a stub that always returns 0. This change is necessary for our unit testing suite to pass under node.js.Have no need to be added to AUTHORS for such a trivial change.
Closes #10765