New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise CollectError if import test module fails #1520

Merged
merged 1 commit into from Apr 26, 2016

Conversation

Projects
None yet
2 participants
@omarkohl
Contributor

omarkohl commented Apr 17, 2016

A few tests are still failing and need to be fixed. I will do that and adapt the CHANGELOG if the change makes sense.

I honestly don't see much point in fixing #1426 (but did it because it looked simple enough).

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features
  • Make sure to include one or more tests for your change
  • Add yourself to AUTHORS
  • Add a new entry to the CHANGELOG (choose any open position to avoid merge conflicts with other PRs)

One of the reasons for failing to import the test module is invalid Python
identifiers in the full package path of the test module.

fix #1426

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Apr 17, 2016

Thanks! While I agree that this seems like the original user report was a stretch, I don't think it hurts either. 😁

@omarkohl

This comment has been minimized.

Contributor

omarkohl commented Apr 20, 2016

I improved the error message a little, fixed failing tests and added a CHANGELOG entry.

I force pushed the branch instead of adding commits to avoid cluttering the repository.

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Apr 20, 2016

Thanks! The tests are failing because of a minor output detail between Python versions, could you please fix it?

@omarkohl

This comment has been minimized.

Contributor

omarkohl commented Apr 23, 2016

Thanks! The tests are failing because of a minor output detail between Python versions, could you please fix it?

Yep I'm on it.

Raise CollectError if import test module fails
One of the reasons for failing to import the test module is invalid Python
identifiers in the full package path of the test module.

fix #1426
@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Apr 26, 2016

Oh sorry @omarkohl, just now I saw that you did make a new commit. Thanks again!

@nicoddemus nicoddemus merged commit fdee88f into pytest-dev:features Apr 26, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment