Start first line of FixtureLookupErrorRepr messages with an 'E' #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a starting 'E' to the expected error messages. The tests were still passing after the previous patch but I think it's better to have stricter tests.
|
@eolo999 thanks for your work here! |
| @@ -3,6 +3,10 @@ | |||
|
|
|||
| **Bug Fixes** | |||
|
|
|||
| * Add an 'E' to the first line of error messages from FixtureLookupErrorRepr. | |||
| Fixes (`#717`_). Thanks `@blueyed`_ for reporting, `@eolo999`_ for the PR | |||
There was a problem hiding this comment.
Could you drop the parenthesis here? 😁
There was a problem hiding this comment.
Parenthesis removed and PR updated, thanks.
|
Thanks @eolo999! |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Aug 11, 2016
Fixes pytest-dev#717. Follow-up to pytest-dev#1762.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Aug 14, 2016
Fixes pytest-dev#717. Follow-up to pytest-dev#1762.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Aug 14, 2016
Fixes pytest-dev#717. Follow-up to pytest-dev#1762.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Aug 14, 2016
Fixes pytest-dev#717. Follow-up to pytest-dev#1762.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an 'E' to the first line of error messages from FixtureLookupErrorRepr.
Fixes #717.