Revert refactor of old-style to new-style classes #2414
Conversation
As discussed in the mailing list, unfortunately this might break APIs due to the subtle differences between new and old-style classes (see pytest-dev#2398). This reverts commit d4afa15 from PR pytest-dev#2179.
|
As I understand it the original issue will turn into wontfix instead of re-opening, no? I guess other then documenting that this behaviour is different between python 2 and 3 we can't do much about this. |
|
Good point. Alternatively we would have to somehow warn users two versions ahead of time, and I don't see that happening TBH. |
There was a problem hiding this comment.
Looks good to me bug giving @RonnyPfannschmidt a chance to respond on the mailing list
|
Well, in theory we could announce it and then do the change in version 5.0. But I'm kind of being hopeful that dropping python 2.7 would have happened by then. That's probably a bit wishful thinking on my part. But to be fair it's such a subtle change that no one will ever notice wherever we write it in the docs and then stuff will just break in 5.0 and then we'll be able to say "not our fault, told you so" which isn't terribly helpful or user friendly anyway. |
|
Merging as per agreement with @RonnyPfannschmidt on the mailing list. |
As discussed in the mailing list, unfortunately this might break APIs
due to the subtle differences between new and old-style classes (see #2398).
This reverts commit d4afa15 from PR #2179.
After this is merged, we should re-open #2147.