Refactored old style classes to new style classes #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Jan 9, 2017
|
Thanks @RonnyPfannschmidt. Let me know if I need to edit AUTHORS and the CHANGELOG. |
|
@mandeep oh, that would make sense, it is a slight behaviour change after all |
|
I agree that an entry to the CHANGELOG is in order. 👍 Thanks @mandeep for the PR, appreciate it. |
nicoddemus
requested changes
Jan 9, 2017
|
yay - kudos @mandeep 🎉 |
|
Thanks! @RonnyPfannschmidt @nicoddemus |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
May 17, 2017
As discussed in the mailing list, unfortunately this might break APIs due to the subtle differences between new and old-style classes (see pytest-dev#2398). This reverts commit d4afa15 from PR pytest-dev#2179.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added (object) to the end of class names as discussed in #2147. I searched the pytest package folder with the regex "class [A-Z]\w*(?<!():" and added (object) before the colon of each class. The tests passed as expected. Thoughts?