Fix TypeError when first item in MarkInfo list of marks is a MarkDecorator instance #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| combined = attr.ib(repr=False) | ||
|
|
||
| @combined.default | ||
| def _combined_default(self): |
There was a problem hiding this comment.
this is ABSOLUTELY not the place not fix - in addition the python version check makes absolutely no sense
_marks should get a validator that requires its a list of mark objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure I like the fix, but the current state of things of working on Python 3 and failing on Python 2 is not optimal either. 🤔
Fix #3501