Doctest: hack in handling mock style objects

[RonnyPfannschmidt]

Resolves #3456

[nicoddemus]

Just FYI: GitHub is facing some issues so webhooks are disabled for the moment: https://status.github.com/messages

[RonnyPfannschmidt]

i am aware ^^

[codecov]

Codecov Report

Merging #4212 into master will increase coverage by 0.02%.
The diff coverage is 93.1%.

@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
+ Coverage   95.73%   95.75%   +0.02%     
==========================================
  Files         111      111              
  Lines       24686    24947     +261     
  Branches     2446     2503      +57     
==========================================
+ Hits        23632    23887     +255     
- Misses        741      748       +7     
+ Partials      313      312       -1

Flag	Coverage Δ
#docs	29.62% <68.96%> (+0.13%)	⬆️
#doctesting	29.62% <68.96%> (+0.13%)	⬆️
#linting	29.62% <68.96%> (+0.13%)	⬆️
#linux	95.57% <93.1%> (+0.02%)	⬆️
#nobyte	92.43% <62.06%> (+0.05%)	⬆️
#numpy	92.45% <86.2%> (-0.72%)	⬇️
#pexpect	42.15% <68.96%> (+0.05%)	⬆️
#py27	93.82% <62.06%> (+0.06%)	⬆️
#py34	91.92% <75.86%> (+0.11%)	⬆️
#py35	91.88% <79.31%> (+0.04%)	⬆️
#py36	91.89% <79.31%> (+0.04%)	⬆️
#py37	93.09% <79.31%> (-0.82%)	⬇️
#trial	92.45% <86.2%> (-0.72%)	⬇️
#windows	93.95% <93.1%> (+0.02%)	⬆️
#xdist	93.78% <86.2%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
testing/test_doctest.py	100% <100%> (ø)	⬆️
src/_pytest/doctest.py	96.37% <91.66%> (-0.47%)	⬇️
src/_pytest/assertion/util.py	96.96% <0%> (-0.58%)	⬇️
testing/test_assertion.py	97.29% <0%> (-0.22%)	⬇️
src/_pytest/terminal.py	91.76% <0%> (+0.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2359663...a6988aa. Read the comment docs.

[nicoddemus]

Clever solution, awesome!

Please just add a docstring to _is_mocked and _patch_unwrap_mock_aware explaining what's going on to the unaware, including a reference to the issue. 🙇

[nicoddemus]

great, thanks

[twmr]

@RonnyPfannschmidt Thx for this hack! I have applied it in pytest-sphinx as well.

[RonnyPfannschmidt]

@Thisch im glad it could help, i was repulsed as i made it ^^