Remove PyCollector.makeitem

[nicoddemus]

Fix #4535

[codecov]

Codecov Report

Merging #4531 into features will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           features    #4531      +/-   ##
============================================
+ Coverage     95.75%   95.77%   +0.02%     
============================================
  Files           111      111              
  Lines         24970    24954      -16     
  Branches       2462     2462              
============================================
- Hits          23909    23900       -9     
+ Misses          749      747       -2     
+ Partials        312      307       -5

Flag	Coverage Δ
#docs	29.36% <ø> (+0.09%)	⬆️
#doctesting	29.36% <ø> (+0.09%)	⬆️
#linting	29.36% <ø> (+0.09%)	⬆️
#linux	95.58% <ø> (+0.02%)	⬆️
#nobyte	92.43% <ø> (+0.01%)	⬆️
#numpy	93.24% <ø> (+0.03%)	⬆️
#pexpect	41.75% <ø> (+0.04%)	⬆️
#py27	93.82% <ø> (+0.02%)	⬆️
#py34	91.93% <ø> (+0.06%)	⬆️
#py35	91.96% <ø> (+0.06%)	⬆️
#py36	91.97% <ø> (+0.06%)	⬆️
#py37	93.95% <ø> (+0.02%)	⬆️
#trial	93.24% <ø> (+0.03%)	⬆️
#windows	93.98% <ø> (ø)	⬆️
#xdist	93.82% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
testing/python/collect.py	99.36% <ø> (+0.21%)	⬆️
src/_pytest/python.py	93.02% <ø> (-0.03%)	⬇️
testing/deprecated_test.py	100% <ø> (ø)	⬆️
src/_pytest/deprecated.py	100% <ø> (ø)	⬆️
src/_pytest/cacheprovider.py	97.16% <0%> (+0.47%)	⬆️
src/_pytest/terminal.py	92.95% <0%> (+0.83%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb363c8...883fcd7. Read the comment docs.

[codecov]

Codecov Report

Merging #4531 into features will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           features    #4531      +/-   ##
============================================
+ Coverage     95.77%   95.77%   +<.01%     
============================================
  Files           111      111              
  Lines         24970    24954      -16     
  Branches       2462     2462              
============================================
- Hits          23914    23900      -14     
  Misses          747      747              
+ Partials        309      307       -2

Flag	Coverage Δ
#docs	29.35% <ø> (+0.08%)	⬆️
#doctesting	29.35% <ø> (+0.08%)	⬆️
#linting	29.35% <ø> (+0.08%)	⬆️
#linux	95.59% <ø> (ø)	⬆️
#nobyte	92.43% <ø> (+0.01%)	⬆️
#numpy	93.24% <ø> (+0.01%)	⬆️
#pexpect	41.75% <ø> (+0.02%)	⬆️
#py27	93.82% <ø> (ø)	⬆️
#py34	91.93% <ø> (+0.06%)	⬆️
#py35	91.96% <ø> (+0.06%)	⬆️
#py36	91.97% <ø> (+0.06%)	⬆️
#py37	93.95% <ø> (+0.02%)	⬆️
#trial	93.24% <ø> (+0.01%)	⬆️
#windows	93.98% <ø> (ø)	⬆️
#xdist	93.82% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
testing/python/collect.py	99.36% <ø> (+0.21%)	⬆️
src/_pytest/python.py	93.02% <ø> (-0.03%)	⬇️
testing/deprecated_test.py	100% <ø> (ø)	⬆️
src/_pytest/deprecated.py	100% <ø> (ø)	⬆️
src/_pytest/cacheprovider.py	97.16% <0%> (+0.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb363c8...e3d30f8. Read the comment docs.

[nicoddemus]

Updated. 👍