Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when discovery fails while using -p no:terminal #5506

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix crash when discovery fails while using -p no:terminal #5506

merged 1 commit into from
Jun 27, 2019

Conversation

asottile
Copy link
Member

Resolves #5505

@asottile asottile added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jun 27, 2019
@nicoddemus
Copy link
Member

Thanks for the quick fix!

@asottile asottile merged commit f7bfbb5 into pytest-dev:master Jun 27, 2019
@asottile asottile deleted the fix_no_terminal branch June 27, 2019 17:46
@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited
Loading

Codecov Report

Merging #5506 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5506      +/-   ##
==========================================
+ Coverage   96.09%   96.09%   +<.01%     
==========================================
  Files         117      117              
  Lines       25643    25647       +4     
  Branches     2483     2483              
==========================================
+ Hits        24642    24646       +4     
  Misses        696      696              
  Partials      305      305
Impacted Files Coverage Δ
src/_pytest/nodes.py 95.5% <100%> (ø) ⬆️
testing/test_config.py 99.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65fbdf2...4e723d6. Read the comment docs.

@asottile asottile mentioned this pull request Jun 27, 2019
Merged
@asottile asottile added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in pytest 4.4: INTERNALERROR with -p no:terminal --collect-only and crash
2 participants
@asottile @nicoddemus