Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Fix crash when discovery fails while using -p no:terminal #5508

Merged
merged 1 commit into from
Jun 27, 2019
Merged

[4.6] Fix crash when discovery fails while using -p no:terminal #5508

merged 1 commit into from
Jun 27, 2019

Conversation

asottile
Copy link
Member

via #5506

Fix crash when discovery fails while using `-p no:terminal`
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #5508 into 4.6-maintenance will decrease coverage by 56.76%.
The diff coverage is 40%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           4.6-maintenance    #5508       +/-   ##
====================================================
- Coverage            95.92%   39.15%   -56.77%     
====================================================
  Files                  115      115               
  Lines                26433    26437        +4     
  Branches              2610     2472      -138     
====================================================
- Hits                 25355    10352    -15003     
- Misses                 755    15430    +14675     
- Partials               323      655      +332
Impacted Files Coverage Δ
src/_pytest/nodes.py 74.5% <100%> (-20.1%) ⬇️
testing/test_config.py 15.61% <25%> (-83.89%) ⬇️
testing/test_reports.py 10.49% <0%> (-89.51%) ⬇️
testing/logging/test_reporting.py 12.21% <0%> (-87.46%) ⬇️
testing/code/test_excinfo.py 11.63% <0%> (-85.13%) ⬇️
testing/test_collection.py 15.06% <0%> (-84.75%) ⬇️
testing/test_cacheprovider.py 15.36% <0%> (-84.39%) ⬇️
testing/test_junitxml.py 14.06% <0%> (-83.91%) ⬇️
testing/test_pluginmanager.py 16.52% <0%> (-83.48%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554bff8...f4b1c11. Read the comment docs.

@asottile asottile merged commit b85d98e into pytest-dev:4.6-maintenance Jun 27, 2019
@asottile asottile deleted the backport_5506 branch June 27, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant