Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note to writing_plugins.rst #7896

Merged
merged 6 commits into from
Oct 17, 2020

Conversation

nimeshvashistha
Copy link
Contributor

fixes #7212

@nimeshvashistha nimeshvashistha changed the title Update writing_plugins.rst Added note to writing_plugins.rst Oct 14, 2020
doc/en/writing_plugins.rst Outdated Show resolved Hide resolved
doc/en/writing_plugins.rst Outdated Show resolved Hide resolved
@nicoddemus
Copy link
Member

Thanks @nimeshvashistha! Two small tweaks and LGTM! 👍

nimeshvashistha and others added 2 commits October 15, 2020 07:54
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
@The-Compiler
Copy link
Member

#7212 specifically mentions the pytest_collection_modifyitems hook - so I guess something should be added to that hook (rather than just a general notice) as well?

@nimeshvashistha
Copy link
Contributor Author

#7212 specifically mentions the pytest_collection_modifyitems hook - so I guess something should be added to that hook (rather than just a general notice) as well?

Sure, I'm willing to contribute more, can you please guide me a bit about it?

@nicoddemus
Copy link
Member

Sure, I'm willing to contribute more, can you please guide me a bit about it?

I think a note under the pytest_collection_modifyitems hook mentioning that, if implemented in conftest.py files, it always receives all collected items, not only those under the conftest.py.

@nimeshvashistha
Copy link
Contributor Author

Sure, I'm willing to contribute more, can you please guide me a bit about it?

I think a note under the pytest_collection_modifyitems hook mentioning that, if implemented in conftest.py files, it always receives all collected items, not only those under the conftest.py.

alright, I've made the changes.

doc/en/reference.rst Outdated Show resolved Hide resolved
doc/en/reference.rst Outdated Show resolved Hide resolved
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nimeshvashistha!

(We should squash merge this PR)

@nicoddemus nicoddemus merged commit 991bc7b into pytest-dev:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest_collection_modifyitems in subdir conftest recieves all tests
3 participants