Improve and add basic miniKanren goals #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XXX: `eq_assoccomm` is broken and needs to be updated to handle the now relational `permuteq`/`permuteo`, which it relies on via `eq_comm`.
This approach uses associative flattening (e.g. `(op, 1, (op, 2, 3))` is flattened to `(op, 1, 2, 3)`), which now makes nested associative operations possible.
brandonwillard
force-pushed
the
improve-basic-goals
branch
from
31a1519
to
0ea3200
Compare
|
Well, it looks like this PR also fixes some long-standing, fundamental issues with the associative/commutative relations. Both goals (and their combination) are now fully relational and they work with nested terms (i.e. it closes logpy/logpy#7). There's definitely a lot that can be done to make them much more efficient, but first things first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces more of the standard miniKanren goals and rewrites current versions that rely on
EarlyGoalErrorand are not able to handle all valid input types (e.g. goals that can't handle logic variables for some or all arguments).Some new goals:
rembero: a goal representing the relationl.remove(b); l == out, wherelandoutare sequences andbis an element ofl.mapo: unlikemap_anyo, a given binary relation must succeed for every corresponding element pair in the given sequences.Ones that need to be rewritten:
appendomemberopermuteq(rename topermuteo)eq_assoceq_commeq_assoccomm