Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build only one universal wheel when running tox #1154

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Build only one universal wheel when running tox #1154

merged 4 commits into from
Jun 26, 2023

Conversation

hynek
Copy link
Member

@hynek hynek commented Jun 26, 2023

Sadly, hatch-autorun and tox seem to be fighting over env variables so we create the pth file by hand.

Sadly, hatch-autorun and tox seem to be fighting over env variables so
we create the pth file by hand.
@hynek
Copy link
Member Author

hynek commented Jun 26, 2023

OK, this is interesting. @gaborbernat it looks like SETUPTOOLS_SCM_PRETEND_VERSION is not passed through when using the shared build environment despite being in [testenv]'s pass_env.

I couldn't find a way to affect env variables for it (which is why I gave up on hatch-autorun that needs one) – any advice? Would you consider this a bug in tox?

@gaborbernat
Copy link
Contributor

OK, this is interesting. @gaborbernat it looks like SETUPTOOLS_SCM_PRETEND_VERSION is not passed through when using the shared build environment despite being in [testenv]'s pass_env.

I couldn't find a way to affect env variables for it (which is why I gave up on hatch-autorun that needs one) – any advice? Would you consider this a bug in tox?

https://tox.wiki/en/latest/upgrading.html#packaging-configuration-and-inheritance ?

Co-authored-by: Bernát Gábor <690238+gaborbernat@users.noreply.github.com>
@hynek
Copy link
Member Author

hynek commented Jun 26, 2023

@gaborbernat omg thanks, can't believe I couldn't find it! this was the last puzzle piece.

@hynek hynek merged commit e920b7b into main Jun 26, 2023
@hynek hynek deleted the share-wheel branch June 26, 2023 14:18
@gaborbernat
Copy link
Contributor

You're welcome!

@gaborbernat
Copy link
Contributor

Note the new config subcommand tox c -e py311 -k pass_env set_env that would have allowed you to inspect these settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants