Fix day period formatting (#378) #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zh_Hant` locale data does not have names for the `am` and `pm` day periods in the `format`/`abbreviated` context, so fallback logic is added to deal with that eventuality. Fixes python-babel#378
Current coverage is
|
|
I kinda want the same stuff @codecov-io is smoking... |
|
Self-merging as this is a regression fix. The only failing CI is Codecov, which is on some sort of robot drugs... as usual. |
Closed
This was referenced Aug 17, 2017
This was referenced Aug 26, 2017
This was referenced Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #378 for discussion.
We should release 2.3.2 when this fix is in, if no other bugs/regressions are found.