Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _locales_to_names (Fix for #1037) #1038

Merged

Conversation

DI84
Copy link
Contributor

@DI84 DI84 commented Oct 24, 2023

Call str() on the parameter variable instead of the module object.

@DI84 DI84 changed the title Fix _locales_to_names Fix _locales_to_names (Fix for #1037) Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1038 (7784a6f) into master (eeb2feb) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   90.50%   90.30%   -0.21%     
==========================================
  Files          25       25              
  Lines        4391     4393       +2     
==========================================
- Hits         3974     3967       -7     
- Misses        417      426       +9     
Files Coverage Δ
babel/support.py 84.76% <0.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

@akx akx enabled auto-merge (squash) October 24, 2023 14:19
@akx akx merged commit 139dc11 into python-babel:master Oct 24, 2023
24 of 26 checks passed
@DI84 DI84 deleted the fix-local-to-list-of-languages-conversion branch October 25, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants