-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract: Add npgettext to default keywords map #341
Conversation
Current coverage is
|
@sudheesh001 Thanks! I'll take a closer look later tonight. |
@@ -38,7 +38,8 @@ | |||
'dgettext': (2,), | |||
'dngettext': (2, 3), | |||
'N_': None, | |||
'pgettext': ((1, 'c'), 2) | |||
'pgettext': ((1, 'c'), 2), | |||
'npgettext': ((1, 'c', 2, 3)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tuple should be ((1, 'c'), 2, 3)
?
I.e. that the first argument is c
ontext and 2 and 3 are messages.
@sudheesh001 also the same commit message guidelines apply here too (although they're not that strictly enforced) |
Add the npgettext as a default keyword in the keywords map. Create test_npgettext in test_extract showing the passing tests. Fixes python-babel#281 Fixes python-babel#328
This looks good! Thank you for the patch, @sudheesh001 ! |
Extract: Add npgettext to default keywords map
Add the npgettext as a default keyword in the keywords map.
Create test_npgettext in test_extract showing the passing tests.
Fixes #281
Fixes #328