Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for b and B period symbols in time format #869

Merged
merged 3 commits into from
May 10, 2022

Conversation

jun66j5
Copy link
Contributor

@jun66j5 jun66j5 commented Apr 29, 2022

Fix for #866

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #869 (38a0e42) into master (3ae5402) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   91.34%   91.29%   -0.05%     
==========================================
  Files          23       23              
  Lines        4192     4183       -9     
==========================================
- Hits         3829     3819      -10     
- Misses        363      364       +1     
Impacted Files Coverage Δ
babel/dates.py 92.50% <100.00%> (-0.05%) ⬇️
babel/localtime/_unix.py 23.61% <0.00%> (-1.05%) ⬇️
babel/localtime/__init__.py 64.10% <0.00%> (-0.90%) ⬇️
babel/messages/checkers.py 80.00% <0.00%> (-0.25%) ⬇️
babel/messages/jslexer.py 86.66% <0.00%> (-0.15%) ⬇️
babel/messages/mofile.py 89.88% <0.00%> (-0.12%) ⬇️
babel/support.py 84.55% <0.00%> (-0.07%) ⬇️
babel/messages/frontend.py 87.91% <0.00%> (-0.05%) ⬇️
babel/messages/extract.py 94.87% <0.00%> (-0.04%) ⬇️
... and 13 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks pretty good! Some minor comments within :)

babel/dates.py Show resolved Hide resolved
babel/dates.py Outdated Show resolved Hide resolved
babel/dates.py Outdated Show resolved Hide resolved
@akx akx self-assigned this May 10, 2022
@akx akx added this to the Babel 2.11 milestone May 10, 2022
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and the fast review turnaround, looks great! :)

@akx akx merged commit d0ec73d into python-babel:master May 10, 2022
@akx akx modified the milestones: Babel 2.11, Babel 2.10.2 Jun 14, 2022
@jun66j5 jun66j5 deleted the date-period-symbols branch June 23, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants