-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for b
and B
period symbols in time format
#869
Conversation
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 91.34% 91.29% -0.05%
==========================================
Files 23 23
Lines 4192 4183 -9
==========================================
- Hits 3829 3819 -10
- Misses 363 364 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks pretty good! Some minor comments within :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and the fast review turnaround, looks great! :)
Fix for #866