Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudWatch custom dimensions and boto3 #679

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CloudWatch custom dimensions and boto3 #679

wants to merge 5 commits into from

Conversation

jantman
Copy link

@jantman jantman commented Oct 6, 2017

This rolls up two improvements for the cloudwatch handler:

  1. Fix CloudWatch handler uses deprecated SDK #678, switch from the deprecated boto AWS library (which, in addition to being deprecated, also doesn't support retrieving AWS credentials from the Instance Metadata Service or ECS Task Metadata).
  2. Add support for custom dimensions to send along with metrics, per-metric.

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 24.649% when pulling 4d99403 on jantman:cw-custom-dimension into f2bece4 on python-diamond:master.

@shortdudey123
Copy link
Member

#707 added custom dimension support. Can you rebase this to get the boto3 switch done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs: rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudWatch handler uses deprecated SDK
3 participants
@jantman @coveralls @shortdudey123