Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderation commands don't compare role hierachy of caller and "moderated" #134

Closed
pydis-bot opened this issue Nov 17, 2018 · 3 comments
Closed
Assignees
Labels
a: moderation Related to community moderation functionality: (moderation, defcon, verification) t: bug Something isn't working

Comments

@pydis-bot
Copy link

Originally posted by Thomas Petersson:

Since the bot straight out bans, kicks, etc. after posting an infraction, won't it be possible for moderators to ban admins. Given the bots role is above admins. This makes it more of a trust based implementation over restricted.

In my opinion admins should not be able to moderate other admins, and moderators should definitely not be able to moderate admins (owners are above the bot in the hierarchy and can't be effected)

attempted murder

If it was not for the fact that joseph is an owner (and super duper owner) and the bot is under owner role in the hierarchy that may have very well gone through. (We were curious, didn't intend to try to ban Joseph)

@pydis-bot pydis-bot added the Cogs label Nov 17, 2018
@pydis-bot
Copy link
Author

Comment from Johannes Christ:

This is a honeypot to find untrustworthy mods. Don't tell the other mods. ㊙️

@sco1 sco1 self-assigned this Jan 7, 2019
@sco1
Copy link
Contributor

sco1 commented Jan 7, 2019

Should this be enforced for all moderation commands or just a subset?

@jchristgit
Copy link
Member

I think only kick / ban / tempban should be fine. The others are often used for tests.

sco1 added a commit that referenced this issue Jan 9, 2019
Per #134, only implement for all variations of the ban & kick infractions

Update helper method inputs to facilitate a generic logging & context message
@MarkKoz MarkKoz added a: moderation Related to community moderation functionality: (moderation, defcon, verification) t: bug Something isn't working labels Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: moderation Related to community moderation functionality: (moderation, defcon, verification) t: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants