Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helpcog dm features #2968

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Remove helpcog dm features #2968

merged 2 commits into from
Mar 26, 2024

Conversation

ChrisLovering
Copy link
Member

Closes #1481

@ChrisLovering ChrisLovering mentioned this pull request Mar 24, 2024
Closed
Xithrius
Xithrius approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Xithrius Xithrius requested review from GDWR and mbaruh March 25, 2024 00:06
@Xithrius Xithrius added p: 2 - normal Normal Priority a: help channels Related to the help channel system t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels Mar 25, 2024
@wookie184
Copy link
Contributor

Part of the idea behind DMing authors when they open a help thread was to provide a way for them to look back on past threads they've opened, which is an issue that forum channels didn't really help with.

It's not vital since there are other ways of finding your threads (e.g. searching for pinned messages sent by you in the help forum channel), but since it's a fairly harmless feature and I don't think this use case was discussed I figured I'd mention it.

@ChrisLovering
Copy link
Member Author

Part of the idea behind DMing authors when they open a help thread was to provide a way for them to look back on past threads they've opened, which is an issue that forum channels didn't really help with.

It's not vital since there are other ways of finding your threads (e.g. searching for pinned messages sent by you in the help forum channel), but since it's a fairly harmless feature and I don't think this use case was discussed I figured I'd mention it.

Quite a few people have been annoyed with the DMs from the bot from that feature specifically. I wdoner if we merge this PR, and add an issue to add it back in a form that can be opt-ed out of?

@wookie184
Copy link
Contributor

Quite a few people have been annoyed with the DMs from the bot from that feature specifically. I wdoner if we merge this PR, and add an issue to add it back in a form that can be opt-ed out of?

Yeah that sounds good, I guess we can see if people mention that they still find it useful once we've removed it and add it back as opt-out or opt-in if that is the case.

@ChrisLovering ChrisLovering mentioned this pull request Mar 26, 2024
Open
@ChrisLovering
Remove the help-dm feature
6c37f6d 
This feature allowed users to opt-in to getting DMs from the bot whenever someone messaged in a help channel they we participating in. This was useful in the old channel-based help system as it was hard to remember which channels you were participating in.

Now that we've moved over to the forum channel, this is no longer an issue, as posts you are participating in now appear in the channel list, and others don't.
@ChrisLovering
Remove the DM sent to users when they open a help post
2994592 
This is no longer needed now that the new forum channel used for the help system automatically have the new post shown in the channel list
@ChrisLovering ChrisLovering merged commit 2994592 into main Mar 26, 2024
5 checks passed
@ChrisLovering ChrisLovering deleted the remove-helpcog-dm-features branch March 26, 2024 15:29
@wookie184 wookie184 mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xithrius Xithrius Xithrius approved these changes

@MarkKoz MarkKoz MarkKoz approved these changes

@GDWR GDWR Awaiting requested review from GDWR

@mbaruh mbaruh Awaiting requested review from mbaruh

Assignees
No one assigned
Labels
a: help channels Related to the help channel system p: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opt-out of DMs when opening a help channel
4 participants
@ChrisLovering @wookie184 @MarkKoz @Xithrius