Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cog for random scary movie #23

Merged
merged 4 commits into from
Oct 9, 2018
Merged

Conversation

gables
Copy link
Contributor

@gables gables commented Oct 7, 2018

For issue #9: Random scary movie generator.

Currently picks a random "Halloween" movie. We still need to figure out some kind of list of scary movies to randomly select from.

@jodth07
Copy link
Contributor

jodth07 commented Oct 7, 2018

I am not sure if omdb have by genre in their api.
OMDB seems to though

@lemonsaurus
Copy link
Member

I think that for the purposes of this hacktoberfest, retrieving a random halloween movie will be good enough.

Copy link
Member

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A solid start, Would approve of this if the bot returned something a bit more visually stimulating. An embed with a movie poster would be great, if possible.

bot/cogs/movie.py Outdated Show resolved Hide resolved
bot/cogs/movie.py Show resolved Hide resolved
@gables
Copy link
Contributor Author

gables commented Oct 8, 2018

I am not sure if omdb have by genre in their api.
OMDB seems to though

I wasn't aware of themoviedb, but their api is way fancier. Thanks for the tip

@gables
Copy link
Contributor Author

gables commented Oct 9, 2018

Switched from omdb to tmdb's api for the advanced search filters. !movie also now embeds the movie poster + info instead of just linking to an outside website.
screen shot 2018-10-09 at 1 05 32 am

@lemonsaurus
Copy link
Member

That looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants