Add Hacktoberfest user stats cog #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
bot/cogs/hacktoberstats.py
Outdated
|
|
||
| Otherwise, return None | ||
| """ | ||
| queryURL = f"https://api.github.com/search/issues?q=-label:invalid+type:pr+is:public+author:{username}+created:2018-10-01..2018-10-31&per_page=300" |
There was a problem hiding this comment.
Can this be split into multiple lines? maybe one new line for each new filter on the search.
There was a problem hiding this comment.
Something like:
base_url = "https://api.github.com/search/issues?q="
not_label = "invalid"
action_type = "pr"
is_query = f"public+author:{username}"
date_range = "2018-10-01..2018-10-31"
per_page = "300"
query_url = f"{base_url}-label:{not_label}+type:{action_type}+is:{is_query}+created:{date_range}&per_page={per_page}"Or should I go with a concatenated multi-line string?
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
reviewed
Oct 5, 2018
jb3
requested changes
Oct 5, 2018
|
Might want to run this through flake8 to clear up some of the syntactical errors I missed in the reviews. |
Adjust variable & function names to be more in line with PEP8's recommendations. Break API query URL into multiple parts to aid readability and customization Adjust command input to explicitly accept a username input rather than star packing & unpacking. d.py guards against too many inputs for us Change _getURL to _get_shortname and adjust documentation because we're not even doing what the function name and documentation said we were
jb3
requested changes
Oct 7, 2018
Spoooooky
See: Casper, the Friendly Ghost
lemonsaurus
approved these changes
Oct 7, 2018
jb3
approved these changes
Oct 7, 2018
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial functionality for #6 for review.
There are a few typos to fix but they'll be squashed in with changes from review.