-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Electron + CreateReactApp Eexample #696
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to work out issue related to process not terminating properly on Electron window close, will reopen then. |
…option to include modified package.json in build folder using . Included to facilitate build process.
…package.json in build folder
…g to build command in build.sh file.
Python app terminates correctly now when Electron is closed, using: in main.js
in App.tsx
and in eel_electron_CRA.py
|
Currently main.js uses this configuration (may need improvements) as discussed here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #216, #57, #428
Relates to #285, #544, #266, #607, #159, #491
build.sh
file for convenience.npm install
, then run./build.sh
, or follow instructions in README.md.download_electron.sh
to get Electron version for your chip (Intel or ARM).Also somewhat followed this article as reference to configure CRA app with Electron.