-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database profiler - Integration with SQLTap #412
Comments
The current (Dec 2018) GINO implementation of SQLAlchemy engine is different comparing to vanilla SQLAlchemy engine over DB-API. Vanilla SQLAlchemy calls Let me see what can be done for SQLTap, I'll get back to you a bit later. In short, GINO should modify the time when the |
@tng10 This PR should at least make sqltap run. But if you use |
@fantix Thank you for the quick response. I think this PR will cover a lot of cases when analyzing database queries, for sure it will be interesting to have things like Thanks again! |
Okay good to know! Let's get this merged and address the rest in a new issue. Thanks for the info! |
Hi, I am trying to integrate SQLTap into a project with Sanic and GINO.
Description
I am basically using the most basic example of SQLTap, which is the following:
What is going on behind the scenes on SQLTap is the class QueryStats is being instantiated and the parameter results which is suppose to be an instance of sqlalchemy.engine.ResultProxy, actually is a instance of gino.dialects.base._ResultProxy. I did a very basic comparison between ResultProxy class from SQLAlchemy and _ResultProxy class from Gino and I noticed there are methods/attributes omitted. Is there any reason to not have these attributes there? Is there a way to access the ResultProxy instance from SQLAlchemy?
When I execute this code, I receive the error described underneath.
Traceback
Thank you!
The text was updated successfully, but these errors were encountered: