Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NaN #63

Merged
merged 19 commits into from
Oct 26, 2022
Merged

Handle NaN #63

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6d2dcf6
Bug-Fix: handle NaN
The-Debarghya Oct 5, 2022
414fe73
handle NaN and Inf
The-Debarghya Oct 5, 2022
69dcb60
handle inf
The-Debarghya Oct 5, 2022
b4dbe70
-inf and +inf
The-Debarghya Oct 6, 2022
f701644
Add tests for inf and nan
The-Debarghya Oct 6, 2022
c8b859b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 6, 2022
3c61efd
Update number.py
The-Debarghya Oct 9, 2022
f43a915
Update number.py
The-Debarghya Oct 9, 2022
14cbcb1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 9, 2022
31ad331
Merge remote-tracking branch 'origin/main' into bug-62-handle-nan
The-Debarghya Oct 12, 2022
c0a1106
Update number.py
The-Debarghya Oct 12, 2022
05f6c0f
Add docstring in number.py
The-Debarghya Oct 12, 2022
9245532
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 12, 2022
b46e0d5
Add tests
The-Debarghya Oct 12, 2022
e543798
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 12, 2022
6b33558
Update number.py
The-Debarghya Oct 12, 2022
e7f5c2b
Update number.py
The-Debarghya Oct 12, 2022
b72d21c
Update number.py
The-Debarghya Oct 13, 2022
e64ad9e
Simplify
hugovk Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/humanize/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,12 @@ def metric(value: float, unit: str = "", precision: int = 3) -> str:
Returns:
str:
"""
exponent = int(math.floor(math.log10(abs(value)))) if value != 0 else 0
if math.isnan(value):
return "NaN"
elif value != 0:
exponent = int(math.floor(math.log10(abs(value))))
else:
exponent = 0
hugovk marked this conversation as resolved.
Show resolved Hide resolved

if exponent >= 27 or exponent < -24:
return scientific(value, precision - 1) + unit
Expand Down