Make all sentinel values inspectable by IDEs #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 910 919 +9
Branches 175 173 -2
=====================================
+ Hits 910 919 +9
Continue to review full report at Codecov.
|
|
Recommending a Squash Merge to hide those silly mistakes I made in GitHubs web editor. :) |
njsmith
reviewed
Oct 12, 2018
h11/_state.py
Outdated
| @@ -114,20 +114,31 @@ | |||
| from ._events import * | |||
| from ._util import LocalProtocolError, make_sentinel | |||
|
|
|||
| # Everything in __all__ gets re-exported as part of the h11 public API. | |||
There was a problem hiding this comment.
I think we can keep this comment :-)
|
Done! :) |
|
Awesome, thanks! |
|
Oh, I forgot to squash. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCharm has difficulty inspecting values that are both dynamically added to
__all__and created viaglobals()[x] = .... To the detriment of "only-update-one-place" I think it's valuable to have these values inspectable given how frequently they show up in a users codebase when using this library.