-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all sentinel values inspectable by IDEs #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 910 919 +9
Branches 175 173 -2
=====================================
+ Hits 910 919 +9
Continue to review full report at Codecov.
|
Recommending a Squash Merge to hide those silly mistakes I made in GitHubs web editor. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick, otherwise looks good to me.
h11/_state.py
Outdated
@@ -114,20 +114,31 @@ | |||
from ._events import * | |||
from ._util import LocalProtocolError, make_sentinel | |||
|
|||
# Everything in __all__ gets re-exported as part of the h11 public API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep this comment :-)
Done! :) |
Awesome, thanks! |
Oh, I forgot to squash. Sorry! |
PyCharm has difficulty inspecting values that are both dynamically added to
__all__
and created viaglobals()[x] = ...
. To the detriment of "only-update-one-place" I think it's valuable to have these values inspectable given how frequently they show up in a users codebase when using this library.