An attempt at modernization and annotations. #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Sachaa-Thanasius
changed the title
… 3.8+ - Also, get back 100% coverage.
…3986 into feature/annotations
for more information, see https://pre-commit.ci
…ng-wise (e.g. lowercasing hex in unicode).
…orkflow. - pyright-python doesn't seem to work in pre-commit, so shift it to github workflow. - tox.ini: replace black + flake8 with ruff; add typing env for pyright; remove redundant options.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize many of these changes are a massive overreach, especially since they adjust your workflow tools, project configuration, code style, etc.. I'm using this more as an exploratory space and also to see if any components stand out to you as having merit in a separate, smaller-scale PR, e.g. the type annotations. Hope that's okay!
EDIT: For the record, I'm not married to any of the major config/workflow changes. I just wanted to try them and see what happens.