Create a cache for snippets #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ccordoba12
commented
Sep 7, 2021
ccordoba12
commented
- This builds on top of the excellent work done by @krassowski on PR Implement cached label resolution and label resolution limit #26 to build a cache for snippets.
- As with labels, this increases completions speed dramatically.
|
Looks good to me. I won't have time to properly test it until next week though. |
|
No prob, I can wait for your review. |
|
Hey @krassowski, any news on this? |
|
Sorry, not yet! Feel free to merge - I will take time to look at it ultimately and create a follow up PR if find anything in need of improvement. |
krassowski
approved these changes
Oct 4, 2021
andfoy
reviewed
Oct 4, 2021
| @@ -22,8 +22,8 @@ This server can be configured using `workspace/didChangeConfiguration` method. E | |||
| | `pylsp.plugins.jedi_completion.include_class_objects` | `boolean` | Adds class objects as a separate completion item. | `true` | | |||
| | `pylsp.plugins.jedi_completion.fuzzy` | `boolean` | Enable fuzzy when requesting autocomplete. | `false` | | |||
| | `pylsp.plugins.jedi_completion.eager` | `boolean` | Resolve documentation and detail eagerly. | `false` | | |||
| | `pylsp.plugins.jedi_completion.resolve_at_most_labels` | `number` | How many labels (at most) should be resolved? | `25` | | |||
| | `pylsp.plugins.jedi_completion.cache_labels_for` | `array` of `string` items | Modules for which the labels should be cached. | `["pandas", "numpy", "tensorflow", "matplotlib"]` | | |||
| | `pylsp.plugins.jedi_completion.resolve_at_most` | `number` | How many labels and snippets (at most) should be resolved? | `25` | | |||
There was a problem hiding this comment.
We need to document this backwards compatibility difference somewhere to let clients that these flags have changed names.
There was a problem hiding this comment.
Ah, ok, I totally agree with that. Will do it in our release notes when 1.3.0 is out.
|
any hope to have this soon ? |
ccordoba12
force-pushed
the
snippets-cache
branch
from
be7042a
to
d92e90a
Compare
|
It will come along with Spyder 5.2.0, to be released in November. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.